Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2886233004: Generate diffing functions for generated subgroup InheritedData in ComputedStyle (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 2375dd056bf312629dc9279eec4949984a287521..12b87ec62ae57cae5085a2077a4124b7d5e5e46e 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -723,16 +723,6 @@ bool ComputedStyle::DiffNeedsFullLayoutAndPaintInvalidation(
other.inherited_data_->font_.LoadingCustomFonts())
return true;
- if (inherited_data_.Get() != other.inherited_data_.Get()) {
- if (inherited_data_->line_height_ != other.inherited_data_->line_height_ ||
- inherited_data_->font_ != other.inherited_data_->font_ ||
- inherited_data_->horizontal_border_spacing_ !=
- other.inherited_data_->horizontal_border_spacing_ ||
- inherited_data_->vertical_border_spacing_ !=
- other.inherited_data_->vertical_border_spacing_)
- return true;
- }
alancutter (OOO until 2018) 2017/05/19 01:16:58 Haha, this is so much easier to read in the genera
nainar 2017/05/19 01:18:19 OMG I never realized - even more reason to generat
-
if (BoxDirection() != other.BoxDirection() ||
RtlOrdering() != other.RtlOrdering() ||
GetTextAlign() != other.GetTextAlign() ||

Powered by Google App Engine
This is Rietveld 408576698