Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2886233004: Generate diffing functions for generated subgroup InheritedData in ComputedStyle (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // This file specifies the fields we want to diff in the various diff function s 2 // This file specifies the fields we want to diff in the various diff function s
3 // in ComputedStyle. 3 // in ComputedStyle.
4 4
5 parameters: { 5 parameters: {
6 // The name parameter represents the name of the function to be created. 6 // The name parameter represents the name of the function to be created.
7 7
8 fields_to_diff: { 8 fields_to_diff: {
9 }, 9 },
10 10
11 // A list of methods to diff (these can be public getters of fields or 11 // A list of methods to diff (these can be public getters of fields or
12 // functions that use fields to determine a value). 12 // functions that use fields to determine a value).
13 // Each entry is expressed as a dict of two fields. 13 // Each entry is expressed as a dict of two fields.
14 // The fields are method - the method to be diffed and field_dependencies 14 // The fields are method - the method to be diffed and field_dependencies
15 // which lists the properties this method depends on. 15 // which lists the properties this method depends on.
16 methods_to_diff: { 16 methods_to_diff: {
17 default: [], 17 default: [],
18 }, 18 },
19 }, 19 },
20 data: [ 20 data: [
21 { 21 {
22 name: "ScrollAnchorDisablingPropertyChanged", 22 name: "ScrollAnchorDisablingPropertyChanged",
23 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "margin-top", "margin-left", "margin-right", "margin-bottom", 23 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "margin-top", "margin-left", "margin-right", "margin-bottom",
24 "left", "right", "top", "bottom", "padding-top", 24 "left", "right", "top", "bottom", "padding-top",
25 "padding-left", "padding-right", "padding-bottom"] 25 "padding-left", "padding-right", "padding-bottom"]
26 }, 26 },
27 { 27 {
28 name: "DiffNeedsFullLayoutAndPaintInvalidation", 28 name: "DiffNeedsFullLayoutAndPaintInvalidation",
29 fields_to_diff: ["padding-top", "padding-left", "padding-right", 29 fields_to_diff: ["padding-top", "padding-left", "padding-right",
30 "padding-bottom"], 30 "padding-bottom", "line-height", "font", "-webkit-border-horizon tal-spacing", "-webkit-border-vertical-spacing"],
shend 2017/05/18 22:17:51 weird line wrapping from rietveld :/
nainar 2017/05/19 00:00:38 I ran git cl format over this and it stayed the sa
shend 2017/05/19 00:09:18 oh it's not the code itself, it's way it's present
nainar 2017/05/19 00:15:02 The side by side diff is a bit weird ok - I had it
alancutter (OOO until 2018) 2017/05/19 01:16:58 I don't think git cl format does Python.
31 methods_to_diff: [ 31 methods_to_diff: [
32 { 32 {
33 method: "BorderLeftWidth()", 33 method: "BorderLeftWidth()",
34 field_dependencies: ["border-left-width"] 34 field_dependencies: ["border-left-width"]
35 }, 35 },
36 { 36 {
37 method: "BorderTopWidth()", 37 method: "BorderTopWidth()",
38 field_dependencies: ["border-top-width"] 38 field_dependencies: ["border-top-width"]
39 }, 39 },
40 { 40 {
41 method: "BorderBottomWidth()", 41 method: "BorderBottomWidth()",
42 field_dependencies: ["border-bottom-width"] 42 field_dependencies: ["border-bottom-width"]
43 }, 43 },
44 { 44 {
45 method: "BorderRightWidth()", 45 method: "BorderRightWidth()",
46 field_dependencies: ["border-right-width"] 46 field_dependencies: ["border-right-width"]
47 } 47 }
48 ] 48 ]
49 }, 49 },
50 { 50 {
51 name: "DiffNeedsFullLayout", 51 name: "DiffNeedsFullLayout",
52 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"] 52 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"]
53 } 53 }
54 ], 54 ],
55 } 55 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698