Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2886233003: [CRD iOS] Fix the leaky RemotingClient (Closed)

Created:
3 years, 7 months ago by Yuwei
Modified:
3 years, 7 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Fix the leaky RemotingClient Previously RemotingClient was not able to clean up itself after the session ended due to retain loops. This CL fixed the retain loops and other thread issues hidden by the fact that RemotingClient and its resources were not released after the session ends. BUG=724228 Review-Url: https://codereview.chromium.org/2886233003 Cr-Commit-Position: refs/heads/master@{#472965} Committed: https://chromium.googlesource.com/chromium/src/+/2b366b970abadb9d9f05ef314da12973fb831f24

Patch Set 1 #

Patch Set 2 : WIP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M remoting/ios/app/host_view_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/ios/app/remoting_view_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/ios/display/gl_display_handler.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/ios/session/remoting_client.mm View 1 4 chunks +24 lines, -7 lines 0 comments Download
M remoting/ios/session/remoting_client_session_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Yuwei
PTAL thanks!
3 years, 7 months ago (2017-05-18 19:27:28 UTC) #3
nicholss
lgtm
3 years, 7 months ago (2017-05-18 21:55:40 UTC) #4
Yuwei
Thanks!
3 years, 7 months ago (2017-05-18 22:06:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886233003/20001
3 years, 7 months ago (2017-05-18 22:08:31 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 23:29:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b366b970abadb9d9f05ef314da1...

Powered by Google App Engine
This is Rietveld 408576698