remoting/ios/display/gl_display_handler.mm - Issue 2886233003: [CRD iOS] Fix the leaky RemotingClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/ios/display/gl_display_handler.mm

Issue 2886233003: [CRD iOS] Fix the leaky RemotingClient (Closed)

Patch Set: WIP Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/ios/display/gl_display_handler.mm

diff --git a/remoting/ios/display/gl_display_handler.mm b/remoting/ios/display/gl_display_handler.mm

index 2f66b09356c04ceaaf15cd557ce79d2d0d8196d3..a71e3d9b2dd7e3e52f96219997b6aeb4361de808 100644

--- a/remoting/ios/display/gl_display_handler.mm

+++ b/remoting/ios/display/gl_display_handler.mm

@@ -78,7 +78,7 @@ class Core : public protocol::CursorShapeStub, public GlRendererDelegate {

EAGLContext* eagl_context_;

std::unique_ptr<GlRenderer> renderer_;

// GlDemoScreen *demo_screen_;

- id<GlDisplayHandlerDelegate> handler_delegate_;

+ __weak id<GlDisplayHandlerDelegate> handler_delegate_;

// Used on display thread.

base::WeakPtr<Core> weak_ptr_;