Remove 'dumpIr' from writeProgram() and KernelTarget.

Remove 'dumpIr' from writeProgram() and KernelTarget.

Debug output should be done where clients need it, not in shared code.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/be1f538bf0fcf402955ad850367438c82696d380

[Siggi Cherem (dart-lang), 2017-05-17 18:34:03]

lgtm, thanks!

I also wanted to pull this out as well.

I have a similar question about verify. At times I want to use it without
writing to disk. One option is to move it up to buildProgram, but it could also
be outside.

[scheglov, 2017-05-17 18:35:18]

On 2017/05/17 18:34:03, Siggi Cherem (dart-lang) wrote:
> lgtm, thanks!
> 
> I also wanted to pull this out as well.
> 
> I have a similar question about verify. At times I want to use it without
> writing to disk. One option is to move it up to buildProgram, but it could
also
> be outside.

Yes, verify() is the next in the queue.
I need to look for the clients of the flag.

[scheglov, 2017-05-17 19:06:09]

Description was changed from

==========
Remove 'dumpIr' from writeProgram() and KernelTarget.

Debug output should be done where clients need it, not in shared code.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Remove 'dumpIr' from writeProgram() and KernelTarget.

Debug output should be done where clients need it, not in shared code.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/be1f538bf0fcf402955ad850367438c82696d380
==========

[scheglov, 2017-05-17 19:06:10]

Committed patchset #1 (id:1) manually as
be1f538bf0fcf402955ad850367438c82696d380 (presubmit successful).

[ahe, 2017-05-22 13:40:18]

--dump-ir is useless now, could you please restore the previous behavior.

https://codereview.chromium.org/2886233002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_target.dart (left):

https://codereview.chromium.org/2886233002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_target.dart:723: for (Library library
in loader.libraries) {
This iterates through the libraries loaded by the source loader.

https://codereview.chromium.org/2886233002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/utils.dart (right):

https://codereview.chromium.org/2886233002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/utils.dart:18: for (Library library in
program.libraries) {
This includes all libraries (including platform.dill).

[scheglov, 2017-05-22 16:49:17]

On 2017/05/22 13:40:18, ahe wrote:
> --dump-ir is useless now, could you please restore the previous behavior.
> 
>
https://codereview.chromium.org/2886233002/diff/1/pkg/front_end/lib/src/fasta...
> File pkg/front_end/lib/src/fasta/kernel/kernel_target.dart (left):
> 
>
https://codereview.chromium.org/2886233002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/kernel/kernel_target.dart:723: for (Library
library
> in loader.libraries) {
> This iterates through the libraries loaded by the source loader.
> 
>
https://codereview.chromium.org/2886233002/diff/1/pkg/front_end/lib/src/fasta...
> File pkg/front_end/lib/src/fasta/kernel/utils.dart (right):
> 
>
https://codereview.chromium.org/2886233002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/kernel/utils.dart:18: for (Library library in
> program.libraries) {
> This includes all libraries (including platform.dill).

https://codereview.chromium.org/2893233003 should make --dump-ir useful again.