Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: pkg/front_end/lib/src/fasta/compile_platform.dart

Issue 2886233002: Remove 'dumpIr' from writeProgram() and KernelTarget. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/compile_platform.dart
diff --git a/pkg/front_end/lib/src/fasta/compile_platform.dart b/pkg/front_end/lib/src/fasta/compile_platform.dart
index 3f99548649e58bacd4b220f4d5767c694b9cb55c..c353d7fa773df5e678b399c9289cd1480bc9377f 100644
--- a/pkg/front_end/lib/src/fasta/compile_platform.dart
+++ b/pkg/front_end/lib/src/fasta/compile_platform.dart
@@ -6,6 +6,7 @@ library fasta.compile_platform;
import 'dart:async' show Future;
+import 'package:front_end/src/fasta/kernel/utils.dart';
import 'ticker.dart' show Ticker;
import 'dart:io' show exitCode;
@@ -79,8 +80,8 @@ Future compilePlatformInternal(CompilerContext c, Ticker ticker, Uri patchedSdk,
await kernelTarget.writeOutline(outlineOutput);
if (exitCode != 0) return null;
- await kernelTarget.buildProgram();
- await kernelTarget.writeProgram(fullOutput,
- dumpIr: c.options.dumpIr, verify: c.options.verify);
+ var program = await kernelTarget.buildProgram();
+ if (c.options.dumpIr) printProgramText(program);
+ await kernelTarget.writeProgram(fullOutput, verify: c.options.verify);
await kernelTarget.writeDepsFile(fullOutput, deps);
}
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698