Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

Issue 2886233002: Remove 'dumpIr' from writeProgram() and KernelTarget. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
index 5a0c8310999f45432ff4977830c0c31b4c689481..6d929ed07cf6d0da5336ea7299a3c6c6e2427709 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
@@ -43,8 +43,6 @@ import 'package:kernel/ast.dart'
import 'package:kernel/binary/ast_to_binary.dart' show BinaryPrinter;
-import 'package:kernel/text/ast_to_text.dart' show Printer;
-
import 'package:kernel/transformations/erasure.dart' show Erasure;
import 'package:kernel/transformations/continuation.dart' as transformAsync;
@@ -301,11 +299,9 @@ class KernelTarget extends TargetImplementation {
}
}
- Future<Null> writeProgram(Uri uri,
- {bool dumpIr: false, bool verify: false}) async {
+ Future<Null> writeProgram(Uri uri, {bool verify: false}) async {
if (loader.first == null) return null;
try {
- if (dumpIr) this.dumpIr();
if (verify) this.verify();
await writeLinkedProgram(uri, _program, isFullProgram: true);
} on InputError catch (e) {
@@ -718,16 +714,6 @@ class KernelTarget extends TargetImplementation {
ticker.logMs("Transformed async methods");
}
- void dumpIr() {
- StringBuffer sb = new StringBuffer();
- for (Library library in loader.libraries) {
ahe 2017/05/22 13:40:18 This iterates through the libraries loaded by the
- Printer printer = new Printer(sb);
- printer.writeLibraryFile(library);
- }
- print("$sb");
- ticker.logMs("Dumped IR");
- }
-
void verify() {
errors.addAll(verifyProgram(_program));
ticker.logMs("Verified program");

Powered by Google App Engine
This is Rietveld 408576698