Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2886223002: [heap] Expand verification of layout changes to non-JSObject objects. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Expand verification of layout changes to non-JSObject objects. On map change of an object this patch checks that - either GC was notified about this change, - or the change leaves the slot set of the object the same. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2886223002 Cr-Commit-Position: refs/heads/master@{#45427} Committed: https://chromium.googlesource.com/v8/v8/+/ee83890103a768829e8298132f97e78d46b681f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +35 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/objects.cc View 5 chunks +10 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
ulan
ptal
3 years, 7 months ago (2017-05-17 18:22:22 UTC) #2
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-18 11:47:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886223002/1
3 years, 7 months ago (2017-05-19 13:09:27 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 13:46:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ee83890103a768829e8298132f97e78d46b...

Powered by Google App Engine
This is Rietveld 408576698