Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2885883004: [heap] Fix verification of unsafe object layout changes. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix verification of unsafe object layout changes. This patch adds HeapObject::set_map_after_allocation method that initializes the map of the object without object layout checks. All other map setters now check that transitions unsafe for concurrent marking properly notify the GC. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2885883004 Cr-Commit-Position: refs/heads/master@{#45403} Committed: https://chromium.googlesource.com/v8/v8/+/6b5e4439724c08ddc5537956be5b46df3ebd327c

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : remove redundant check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -60 lines) Patch
M src/heap/concurrent-marking.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 34 chunks +54 lines, -40 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects-inl.h View 2 chunks +25 lines, -12 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
ulan
ptal
3 years, 7 months ago (2017-05-17 16:58:08 UTC) #3
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-18 11:42:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885883004/40001
3 years, 7 months ago (2017-05-18 18:38:25 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 19:24:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/6b5e4439724c08ddc5537956be5b46df3eb...

Powered by Google App Engine
This is Rietveld 408576698