Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2886193002: Reland of media: Shutdown AudioManager in TestMojoMediaClient (Closed)

Created:
3 years, 7 months ago by xhwang
Modified:
3 years, 7 months ago
Reviewers:
kolos1, alokp
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of media: Shutdown AudioManager in TestMojoMediaClient (patchset #1 id:1 of https://codereview.chromium.org/2890733004/ ) Reason for revert: This was not the cause of the failure, which has been fixed by reverting other CLs. See BUG for details. Original issue's description: > Revert of media: Shutdown AudioManager in TestMojoMediaClient (patchset #3 id:40001 of https://codereview.chromium.org/2886683003/ ) > > Reason for revert: > Layout tests failure ; mojo/module-loading(-manual-deps-loading).html > > BUG=723461 > > Original issue's description: > > media: Shutdown AudioManager in TestMojoMediaClient > > > > By AudioManager API, Shutdown() must be called before destruction. This > > isn't caught by tests because media_service_unittests is only run on > > release builds. > > > > Review-Url: https://codereview.chromium.org/2886683003 > > Cr-Commit-Position: refs/heads/master@{#472225} > > Committed: https://chromium.googlesource.com/chromium/src/+/6e0f47b9cc33450f93d02d238cd4e60dffa89421 > > TBR=alokp@chromium.org,xhwang@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2890733004 > Cr-Commit-Position: refs/heads/master@{#472404} > Committed: https://chromium.googlesource.com/chromium/src/+/36e3810d369c449a7f6659addd6697f7e81132a4 TBR=alokp@chromium.org,kolos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=723461 Review-Url: https://codereview.chromium.org/2886193002 Cr-Commit-Position: refs/heads/master@{#472470} Committed: https://chromium.googlesource.com/chromium/src/+/44f871a7d7cb39ef8bda0aaf75ac31194463f50a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M media/mojo/services/test_mojo_media_client.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
xhwang
Created Reland of media: Shutdown AudioManager in TestMojoMediaClient
3 years, 7 months ago (2017-05-17 16:21:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886193002/1
3 years, 7 months ago (2017-05-17 16:22:01 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 16:22:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44f871a7d7cb39ef8bda0aaf75ac...

Powered by Google App Engine
This is Rietveld 408576698