Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2890733004: Revert of media: Shutdown AudioManager in TestMojoMediaClient (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
Reviewers:
xhwang, alokp
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Shutdown AudioManager in TestMojoMediaClient (patchset #3 id:40001 of https://codereview.chromium.org/2886683003/ ) Reason for revert: Layout tests failure ; mojo/module-loading(-manual-deps-loading).html BUG=723461 Original issue's description: > media: Shutdown AudioManager in TestMojoMediaClient > > By AudioManager API, Shutdown() must be called before destruction. This > isn't caught by tests because media_service_unittests is only run on > release builds. > > Review-Url: https://codereview.chromium.org/2886683003 > Cr-Commit-Position: refs/heads/master@{#472225} > Committed: https://chromium.googlesource.com/chromium/src/+/6e0f47b9cc33450f93d02d238cd4e60dffa89421 TBR=alokp@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2890733004 Cr-Commit-Position: refs/heads/master@{#472404} Committed: https://chromium.googlesource.com/chromium/src/+/36e3810d369c449a7f6659addd6697f7e81132a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M media/mojo/services/test_mojo_media_client.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kolos1
Created Revert of media: Shutdown AudioManager in TestMojoMediaClient
3 years, 7 months ago (2017-05-17 09:58:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890733004/1
3 years, 7 months ago (2017-05-17 09:58:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/36e3810d369c449a7f6659addd6697f7e81132a4
3 years, 7 months ago (2017-05-17 09:59:37 UTC) #6
xhwang
3 years, 7 months ago (2017-05-17 16:21:06 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2886193002/ by xhwang@chromium.org.

The reason for reverting is: This was not the cause of the failure, which has
been fixed by reverting other CLs. See BUG for details..

Powered by Google App Engine
This is Rietveld 408576698