Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 2885943003: Always position floats from fragment->PositionedFloats list. (Closed)

Created:
3 years, 7 months ago by Gleb Lanbin
Modified:
3 years, 7 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always position floats from fragment->PositionedFloats list. BUG=635619 TESTS=8 new test failures All failed tests were investigated and assigned to corresponding bugs. The main reason why they started failing is because we actually started rendering something instead of producing an empty page. Review-Url: https://codereview.chromium.org/2885943003 Cr-Commit-Position: refs/heads/master@{#472884} Committed: https://chromium.googlesource.com/chromium/src/+/737c499089ee23d99d00924586570a25626da738

Patch Set 1 #

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 33 (29 generated)
Gleb Lanbin
3 years, 7 months ago (2017-05-17 18:06:39 UTC) #19
ikilpatrick
lgtm
3 years, 7 months ago (2017-05-18 16:51:26 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885943003/20001
3 years, 7 months ago (2017-05-18 16:52:34 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 18:41:39 UTC) #33
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/737c499089ee23d99d0092458657...

Powered by Google App Engine
This is Rietveld 408576698