|
|
Created:
3 years, 7 months ago by Gleb Lanbin Modified:
3 years, 7 months ago Reviewers:
ikilpatrick CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAlways position floats from fragment->PositionedFloats list.
BUG=635619
TESTS=8 new test failures
All failed tests were investigated and assigned to corresponding bugs.
The main reason why they started failing is because we actually started rendering something instead of producing an empty page.
Review-Url: https://codereview.chromium.org/2885943003
Cr-Commit-Position: refs/heads/master@{#472884}
Committed: https://chromium.googlesource.com/chromium/src/+/737c499089ee23d99d00924586570a25626da738
Patch Set 1 #Patch Set 2 : git rebase #
Messages
Total messages: 33 (29 generated)
Description was changed from ========== Always position floats from fragment->PositionedFloats list. BUG=635619 ========== to ========== Always position floats from fragment->PositionedFloats list. BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Always position floats from fragment->PositionedFloats list. BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== Always position floats from fragment->PositionedFloats list. BUG=635619 ==========
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Always position floats from fragment->PositionedFloats list. BUG=635619 ========== to ========== Always position floats from fragment->PositionedFloats list. BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
Description was changed from ========== Always position floats from fragment->PositionedFloats list. BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== Always position floats from fragment->PositionedFloats list. BUG=635619 ==========
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Always position floats from fragment->PositionedFloats list. BUG=635619 ========== to ========== Always position floats from fragment->PositionedFloats list. BUG=635619 TESTS=8 new test failures All failed tests were investigated and assigned to corresponding bugs. The main reason why they started failing is because we actually started rendering something instead of producing an empty page. ==========
glebl@chromium.org changed reviewers: + ikilpatrick@chromium.org
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ikilpatrick@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495126285856290, "parent_rev": "2dfc7029286f40d73b131760e3b7467c68b8bb17", "commit_rev": "737c499089ee23d99d00924586570a25626da738"}
Message was sent while issue was closed.
Description was changed from ========== Always position floats from fragment->PositionedFloats list. BUG=635619 TESTS=8 new test failures All failed tests were investigated and assigned to corresponding bugs. The main reason why they started failing is because we actually started rendering something instead of producing an empty page. ========== to ========== Always position floats from fragment->PositionedFloats list. BUG=635619 TESTS=8 new test failures All failed tests were investigated and assigned to corresponding bugs. The main reason why they started failing is because we actually started rendering something instead of producing an empty page. Review-Url: https://codereview.chromium.org/2885943003 Cr-Commit-Position: refs/heads/master@{#472884} Committed: https://chromium.googlesource.com/chromium/src/+/737c499089ee23d99d0092458657... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/737c499089ee23d99d0092458657... |