Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2885943003: Always position floats from fragment->PositionedFloats list. (Closed)
Patch Set: git rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
index 19496bce971d6e7d2dba54e9e45b96c3b58add20..eaef3c15f5f05da36e4f6b73f00df14756c828a8 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
@@ -279,13 +279,8 @@ void NGBlockNode::CopyFragmentDataToLayoutBox(
intrinsic_logical_height -= border_and_padding.BlockSum();
layout_box_->SetIntrinsicContentLogicalHeight(intrinsic_logical_height);
- // We may still have unpositioned floats when we reach the root box.
- if (!layout_box_->Parent()) {
- for (const NGPositionedFloat& positioned_float :
- fragment->PositionedFloats()) {
- FloatingObjectPositionedUpdated(positioned_float, layout_box_);
- }
- }
+ for (const NGPositionedFloat& positioned_float : fragment->PositionedFloats())
+ FloatingObjectPositionedUpdated(positioned_float, layout_box_);
for (const auto& child_fragment : fragment->Children()) {
if (child_fragment->IsPlaced())
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698