Rename Target.writeOutline() into computeOutline(), add separate KernelTarget.writeOutline().

Rename Target.writeOutline() into computeOutline(), add separate KernelTarget.writeOutline().

For DillTarget write does not make sense, and even for KernelTarget
we usually don't want to write anything.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e3f4ed94b1be9858420cd334b266d5bfa0b7d740

[Paul Berry, 2017-05-16 20:51:20]

lgtm

[scheglov, 2017-05-16 21:38:29]

Description was changed from

==========
Rename Target.writeOutline() into computeOutline(), add separate
KernelTarget.writeOutline().

For DillTarget write does not make sense, and even for KernelTarget
we usually don't want to write anything.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Rename Target.writeOutline() into computeOutline(), add separate
KernelTarget.writeOutline().

For DillTarget write does not make sense, and even for KernelTarget
we usually don't want to write anything.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e3f4ed94b1be9858420cd334b266d5bfa0b7d740
==========

[scheglov, 2017-05-16 21:38:31]

Committed patchset #1 (id:1) manually as
e3f4ed94b1be9858420cd334b266d5bfa0b7d740 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-05-17 15:18:16]

Thanks for starting this!

BTW - I was thinking of doing something similar to also split writeProgram in
two (buildProgram and writeProgram). 

Here are some general thoughts I had in mind for the future:

- I'd use a consistent name for them (buildOutline and buildProgram or
computeOutline and computeProgram), I slightly prefer "build", 

- Assuming that we need the result, make them both return what they build: that
way we don't have to reach into internals of the targets (like we do with
`sourceTarget.program`)

- possibly move out the "write" piece out of target, and let the callers deal
with IO.


let me know if you agree and I'd be happy to make them.

[scheglov, 2017-05-17 15:20:33]

On 2017/05/17 15:18:16, Siggi Cherem (dart-lang) wrote:
> Thanks for starting this!
> 
> BTW - I was thinking of doing something similar to also split writeProgram in
> two (buildProgram and writeProgram). 
> 
> Here are some general thoughts I had in mind for the future:
> 
> - I'd use a consistent name for them (buildOutline and buildProgram or
> computeOutline and computeProgram), I slightly prefer "build", 
> 
> - Assuming that we need the result, make them both return what they build:
that
> way we don't have to reach into internals of the targets (like we do with
> `sourceTarget.program`)
> 
> - possibly move out the "write" piece out of target, and let the callers deal
> with IO.
> 
> 
> let me know if you agree and I'd be happy to make them.

Yes, I started working on "writeProgram" too.
If you don't mind, I'd like to continue this work.

[Siggi Cherem (dart-lang), 2017-05-17 15:21:23]

On 2017/05/17 15:20:33, scheglov wrote:
> On 2017/05/17 15:18:16, Siggi Cherem (dart-lang) wrote:
> > Thanks for starting this!
> > 
> > BTW - I was thinking of doing something similar to also split writeProgram
in
> > two (buildProgram and writeProgram). 
> > 
> > Here are some general thoughts I had in mind for the future:
> > 
> > - I'd use a consistent name for them (buildOutline and buildProgram or
> > computeOutline and computeProgram), I slightly prefer "build", 
> > 
> > - Assuming that we need the result, make them both return what they build:
> that
> > way we don't have to reach into internals of the targets (like we do with
> > `sourceTarget.program`)
> > 
> > - possibly move out the "write" piece out of target, and let the callers
deal
> > with IO.
> > 
> > 
> > let me know if you agree and I'd be happy to make them.
> 
> Yes, I started working on "writeProgram" too.
> If you don't mind, I'd like to continue this work.

sounds good, go ahead.

[ahe, 2017-05-24 18:28:37]

lgtm