Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

Issue 2885923002: Rename Target.writeOutline() into computeOutline(), add separate KernelTarget.writeOutline(). (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/fasta.dart ('k') | pkg/front_end/lib/src/fasta/target.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
index ec672cb60728db1a4e004e279ef04f89bf385c70..a95e9bd0727deeb1ab7ea2eb3ff9c9293d5326ec 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
@@ -231,7 +231,8 @@ class KernelTarget extends TargetImplementation {
: writeLinkedProgram(uri, program, isFullProgram: isFullProgram);
}
- Future<Program> writeOutline(Uri uri, {CanonicalName nameRoot}) async {
+ @override
+ Future<Null> computeOutline({CanonicalName nameRoot}) async {
if (loader.first == null) return null;
try {
loader.createTypeInferenceEngine();
@@ -255,12 +256,22 @@ class KernelTarget extends TargetImplementation {
loader.checkOverrides(sourceClasses);
loader.prepareInitializerInference();
loader.performInitializerInference();
- if (uri == null) return program;
- return await writeLinkedProgram(uri, program, isFullProgram: false);
} on InputError catch (e) {
- return handleInputError(uri, e, isFullProgram: false);
+ handleInputError(null, e, isFullProgram: false);
} catch (e, s) {
- return reportCrash(e, s, loader?.currentUriForCrashReporting);
+ reportCrash(e, s, loader?.currentUriForCrashReporting);
+ }
+ }
+
+ Future<Null> writeOutline(Uri uri) async {
+ try {
+ if (uri != null) {
+ await writeLinkedProgram(uri, program, isFullProgram: false);
+ }
+ } on InputError catch (e) {
+ handleInputError(uri, e, isFullProgram: false);
+ } catch (e, s) {
+ reportCrash(e, s, loader?.currentUriForCrashReporting);
}
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/fasta.dart ('k') | pkg/front_end/lib/src/fasta/target.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698