Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: pkg/front_end/lib/src/fasta/fasta.dart

Issue 2885923002: Rename Target.writeOutline() into computeOutline(), add separate KernelTarget.writeOutline(). (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/fasta.dart
diff --git a/pkg/front_end/lib/src/fasta/fasta.dart b/pkg/front_end/lib/src/fasta/fasta.dart
index 5408965056608b5fb147bd13c3e05fd653c90000..2c39693f19c9420cedc36153c252e0df6c5e4d13 100644
--- a/pkg/front_end/lib/src/fasta/fasta.dart
+++ b/pkg/front_end/lib/src/fasta/fasta.dart
@@ -144,7 +144,8 @@ class CompileTask {
} else {
inputError(uri, -1, "Unexpected input: $uri");
}
- await dillTarget.writeOutline(null);
+ await dillTarget.computeOutline();
+ await kernelTarget.computeOutline();
await kernelTarget.writeOutline(output);
if (c.options.dumpIr && output != null) {
kernelTarget.dumpIr();
@@ -193,8 +194,8 @@ Future<CompilationResult> parseScriptInFileSystem(
final KernelTarget kernelTarget =
new KernelTarget(fileSystem, dillTarget, uriTranslator, strongMode);
kernelTarget.read(fileName);
- await dillTarget.writeOutline(null);
- program = await kernelTarget.writeOutline(null);
+ await dillTarget.computeOutline();
+ await kernelTarget.computeOutline();
program = await kernelTarget.writeProgram(null);
if (kernelTarget.errors.isNotEmpty) {
return new CompilationResult.errors(kernelTarget.errors
@@ -266,7 +267,7 @@ Future writeDepsFile(Uri script, Uri depsFile, Uri output,
dillTarget, uriTranslator, false, c.uriToSource);
kernelTarget.read(script);
- await dillTarget.writeOutline(null);
+ await dillTarget.computeOutline();
await kernelTarget.loader.buildOutlines();
await kernelTarget.writeDepsFile(output, depsFile,
extraDependencies: extraDependencies);
« no previous file with comments | « pkg/front_end/lib/src/fasta/dill/dill_target.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698