Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 2885773002: Revert of Notify paint for each frame (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Notify paint for each frame (patchset #12 id:220001 of https://codereview.chromium.org/2872793002/ ) Reason for revert: This CL might be a culprit of test flakiness. https://bugs.chromium.org/p/chromium/issues/detail?id=722703#c2 Original issue's description: > Notify paint for each frame > > Currently main frame reports paint timing and subframes report paint > timing via main frame. The desired behavior is that each frame reports > its own paint timing. > > BUG=705315 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2872793002 > Cr-Commit-Position: refs/heads/master@{#471922} > Committed: https://chromium.googlesource.com/chromium/src/+/5c0563522bdf7cb4c56420cd7d39c0139b5f8f1a TBR=chrishtr@chromium.org,bmcquade@chromium.org,panicker@chromium.org,wangxianzhu@chromium.org,zhenw@google.com,zhenw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705315 Review-Url: https://codereview.chromium.org/2885773002 Cr-Commit-Position: refs/heads/master@{#472068} Committed: https://chromium.googlesource.com/chromium/src/+/134190a648fe48fed0486cf8889569863e4a544c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -170 lines) Patch
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 6 chunks +55 lines, -11 lines 0 comments Download
M chrome/test/data/page_load_metrics/empty_iframe.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/page_load_metrics/iframe.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/page_load_metrics/iframes.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/page_load_metrics/main_frame_with_iframe.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/paint/FramePaintTiming.h View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 5 chunks +16 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 3 chunks +15 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kolos1
Created Revert of Notify paint for each frame
3 years, 7 months ago (2017-05-16 12:38:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885773002/1
3 years, 7 months ago (2017-05-16 12:39:16 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 12:40:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/134190a648fe48fed0486cf88895...

Powered by Google App Engine
This is Rietveld 408576698