Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(489)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/page_load_metrics/iframes.html
Issue
2885773002
:
Revert of Notify paint for each frame (Closed)
Patch Set:
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
chrome/test/data/page_load_metrics/empty_iframe.html
chrome/test/data/page_load_metrics/iframe.html
chrome/test/data/page_load_metrics/iframes.html
chrome/test/data/page_load_metrics/main_frame_with_iframe.html
third_party/WebKit/Source/core/frame/FrameView.h
third_party/WebKit/Source/core/frame/FrameView.cpp
third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
third_party/WebKit/Source/core/paint/BUILD.gn
third_party/WebKit/Source/core/paint/FramePaintTiming.h
third_party/WebKit/Source/core/paint/FramePainter.cpp
third_party/WebKit/Source/platform/graphics/paint/PaintController.h
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/test/data/page_load_metrics/iframe.html
('k') |
chrome/test/data/page_load_metrics/main_frame_with_iframe.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 <html>
1 <html>
2 <link rel="stylesheet" href="seamless-iframe.css">
2 <link rel="stylesheet" href="seamless-iframe.css">
3 <body>
3 <body>
4
<iframe src="/title1.html" class="seamless"></iframe>
4
<!-- TODO(crbug/705315): remove '/cross-site/?.com' when fixed. -->
5
<iframe src="/title1.html" class="seamless"></iframe>
5
<iframe src="
/cross-site/b.com
/title1.html" class="seamless"></iframe>
6
<iframe src="/
cross-site/c.com/
title1.html" class="seamless"></iframe>
6 </body>
7 </body>
7 </html>
8 </html>
OLD
NEW
« no previous file with comments
|
« chrome/test/data/page_load_metrics/iframe.html
('k') |
chrome/test/data/page_load_metrics/main_frame_with_iframe.html »
('j') |
no next file with comments »
Issue 2885773002: Revert of Notify paint for each frame (Closed)
Created 3 years, 7 months ago by kolos1
Modified 3 years, 7 months ago
Reviewers: chrishtr, Bryan McQuade, panicker, Xianzhu, zhenw, Zhen Wang
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2885773002:
Revert of Notify paint for each frame (Closed)
