Expose SingleThreadTaskRunnerThreadMode in post_task.h

Expose SingleThreadTaskRunnerThreadMode in post_task.h

BUG=720058
Review-Url: https://codereview.chromium.org/2885513002
Cr-Commit-Position: refs/heads/master@{#472092}
Committed: https://chromium.googlesource.com/chromium/src/+/0c09719b6965b13fac67b09aff251db5c42890fd

[robliao, 2017-05-15 18:38:42]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2017-05-15 18:38:55]

robliao@chromium.org changed reviewers:
+ fdoray@chromium.org, gab@chromium.org

[commit-bot: I haz the power, 2017-05-15 18:39:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-15 19:20:06]

lgtm

Remove default value from base/task_scheduler/task_scheduler.h

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
File base/task_scheduler/post_task.h (right):

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
base/task_scheduler/post_task.h:195: //
base/task_scheduler/single_thread_task_runner_thread_mode.h for |thread_mode|
"See base/task_scheduler/single_thread_task_runner_thread_mode.h"
Obvious to look at the definition of an enum for more details?

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
base/task_scheduler/post_task.h:214: //
base/task_scheduler/single_thread_task_runner_thread_mode.h for |thread_mode|
ditto

[robliao, 2017-05-15 19:22:44]

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
File base/task_scheduler/post_task.h (right):

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
base/task_scheduler/post_task.h:195: //
base/task_scheduler/single_thread_task_runner_thread_mode.h for |thread_mode|
On 2017/05/15 19:20:06, fdoray wrote:
> "See base/task_scheduler/single_thread_task_runner_thread_mode.h"
> Obvious to look at the definition of an enum for more details?

I wanted to avoid duplicating those details here, so a reference seemed to make
more sense.

[gab, 2017-05-15 19:54:29]

lgtm w/ comment

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
File base/task_scheduler/post_task.h (right):

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
base/task_scheduler/post_task.h:224: SingleThreadTaskRunnerThreadMode::SHARED);
remove default in TaskScheduler (it's not intended to be called directly)

[robliao, 2017-05-15 20:58:27]

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
File base/task_scheduler/post_task.h (right):

https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta...
base/task_scheduler/post_task.h:224: SingleThreadTaskRunnerThreadMode::SHARED);
On 2017/05/15 19:54:29, gab wrote:
> remove default in TaskScheduler (it's not intended to be called directly)

Done.

[robliao, 2017-05-15 20:58:56]

The CQ bit was checked by robliao@chromium.org

[robliao, 2017-05-15 20:58:56]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
fdoray@chromium.org
Link to the patchset: https://codereview.chromium.org/2885513002/#ps20001
(title: "Move Default Argument to post_task.h")

[commit-bot: I haz the power, 2017-05-15 20:59:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-15 21:02:26]

https://codereview.chromium.org/2885513002/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_scheduler_impl_unittest.cc (right):

https://codereview.chromium.org/2885513002/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler_impl_unittest.cc:124: case
test::ExecutionMode::SINGLE_THREADED: {
In CL which will introduce real sharding we should also have a test param that
makes this go through both SingleThreadTaskRunnerThreadMode.

[robliao, 2017-05-15 21:19:10]

https://codereview.chromium.org/2885513002/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_scheduler_impl_unittest.cc (right):

https://codereview.chromium.org/2885513002/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler_impl_unittest.cc:124: case
test::ExecutionMode::SINGLE_THREADED: {
On 2017/05/15 21:02:26, gab wrote:
> In CL which will introduce real sharding we should also have a test param that
> makes this go through both SingleThreadTaskRunnerThreadMode.

Agreed.

[commit-bot: I haz the power, 2017-05-15 21:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:35:43]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[robliao, 2017-05-15 21:39:35]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:40:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:48:13]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[robliao, 2017-05-16 03:28:06]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2017-05-16 03:28:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 05:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 05:52:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fdoray, 2017-05-16 12:48:28]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-16 12:49:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 13:56:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494938908786260,
"parent_rev": "0ef599fed1c9ecbeae6b3df47b51bf2673857acd", "commit_rev":
"0c09719b6965b13fac67b09aff251db5c42890fd"}

[commit-bot: I haz the power, 2017-05-16 13:57:10]

Description was changed from

==========
Expose SingleThreadTaskRunnerThreadMode in post_task.h

BUG=720058
==========

to

==========
Expose SingleThreadTaskRunnerThreadMode in post_task.h

BUG=720058

Review-Url: https://codereview.chromium.org/2885513002
Cr-Commit-Position: refs/heads/master@{#472092}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c09719b6965b13fac67b09aff25...
==========

[commit-bot: I haz the power, 2017-05-16 13:57:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0c09719b6965b13fac67b09aff25...