|
|
DescriptionExpose SingleThreadTaskRunnerThreadMode in post_task.h
BUG=720058
Review-Url: https://codereview.chromium.org/2885513002
Cr-Commit-Position: refs/heads/master@{#472092}
Committed: https://chromium.googlesource.com/chromium/src/+/0c09719b6965b13fac67b09aff251db5c42890fd
Patch Set 1 #
Total comments: 5
Patch Set 2 : Move Default Argument to post_task.h #
Total comments: 2
Messages
Total messages: 28 (13 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
robliao@chromium.org changed reviewers: + fdoray@chromium.org, gab@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm Remove default value from base/task_scheduler/task_scheduler.h https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... File base/task_scheduler/post_task.h (right): https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... base/task_scheduler/post_task.h:195: // base/task_scheduler/single_thread_task_runner_thread_mode.h for |thread_mode| "See base/task_scheduler/single_thread_task_runner_thread_mode.h" Obvious to look at the definition of an enum for more details? https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... base/task_scheduler/post_task.h:214: // base/task_scheduler/single_thread_task_runner_thread_mode.h for |thread_mode| ditto
https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... File base/task_scheduler/post_task.h (right): https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... base/task_scheduler/post_task.h:195: // base/task_scheduler/single_thread_task_runner_thread_mode.h for |thread_mode| On 2017/05/15 19:20:06, fdoray wrote: > "See base/task_scheduler/single_thread_task_runner_thread_mode.h" > Obvious to look at the definition of an enum for more details? I wanted to avoid duplicating those details here, so a reference seemed to make more sense.
lgtm w/ comment https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... File base/task_scheduler/post_task.h (right): https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... base/task_scheduler/post_task.h:224: SingleThreadTaskRunnerThreadMode::SHARED); remove default in TaskScheduler (it's not intended to be called directly)
https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... File base/task_scheduler/post_task.h (right): https://codereview.chromium.org/2885513002/diff/1/base/task_scheduler/post_ta... base/task_scheduler/post_task.h:224: SingleThreadTaskRunnerThreadMode::SHARED); On 2017/05/15 19:54:29, gab wrote: > remove default in TaskScheduler (it's not intended to be called directly) Done.
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org, fdoray@chromium.org Link to the patchset: https://codereview.chromium.org/2885513002/#ps20001 (title: "Move Default Argument to post_task.h")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2885513002/diff/20001/base/task_scheduler/tas... File base/task_scheduler/task_scheduler_impl_unittest.cc (right): https://codereview.chromium.org/2885513002/diff/20001/base/task_scheduler/tas... base/task_scheduler/task_scheduler_impl_unittest.cc:124: case test::ExecutionMode::SINGLE_THREADED: { In CL which will introduce real sharding we should also have a test param that makes this go through both SingleThreadTaskRunnerThreadMode.
https://codereview.chromium.org/2885513002/diff/20001/base/task_scheduler/tas... File base/task_scheduler/task_scheduler_impl_unittest.cc (right): https://codereview.chromium.org/2885513002/diff/20001/base/task_scheduler/tas... base/task_scheduler/task_scheduler_impl_unittest.cc:124: case test::ExecutionMode::SINGLE_THREADED: { On 2017/05/15 21:02:26, gab wrote: > In CL which will introduce real sharding we should also have a test param that > makes this go through both SingleThreadTaskRunnerThreadMode. Agreed.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494938908786260, "parent_rev": "0ef599fed1c9ecbeae6b3df47b51bf2673857acd", "commit_rev": "0c09719b6965b13fac67b09aff251db5c42890fd"}
Message was sent while issue was closed.
Description was changed from ========== Expose SingleThreadTaskRunnerThreadMode in post_task.h BUG=720058 ========== to ========== Expose SingleThreadTaskRunnerThreadMode in post_task.h BUG=720058 Review-Url: https://codereview.chromium.org/2885513002 Cr-Commit-Position: refs/heads/master@{#472092} Committed: https://chromium.googlesource.com/chromium/src/+/0c09719b6965b13fac67b09aff25... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0c09719b6965b13fac67b09aff25... |