Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2885373002: [Sensors] Simplify calculation of the reporting period (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Mikhail
Modified:
2 months, 1 week ago
CC:
chromium-reviews, blink-reviews, haraken, wanming.lin_intel.com, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Simplify calculation of the reporting period Now timestamps obtained from the platfrom sensor are used to calculate 'onchange' reporting period for each Sensor instance. Review-Url: https://codereview.chromium.org/2885373002 Cr-Commit-Position: refs/heads/master@{#472741} Committed: https://chromium.googlesource.com/chromium/src/+/cba53d1efc8b57453ce8df26c027da4108b1b924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/accelerometer.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/gyroscope.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/magnetometer.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/OrientationSensor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/OrientationSensor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 4 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (8 generated)
Mikhail
PTAL
2 months, 1 week ago (2017-05-17 12:09:14 UTC) #6
Reilly Grant (use Gerrit)
lgtm
2 months, 1 week ago (2017-05-17 16:16:24 UTC) #7
shalamov
lgtm
2 months, 1 week ago (2017-05-18 07:41:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885373002/1
2 months, 1 week ago (2017-05-18 07:48:03 UTC) #10
commit-bot: I haz the power
2 months, 1 week ago (2017-05-18 08:37:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cba53d1efc8b57453ce8df26c027...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973