DescriptionMD Bookmarks: Improve keyboard shortcut targeting
Keyboard shortcuts are no longer triggered by a global event listener
looking at all events on the page. Instead, we process keyboard
shortcuts as part of the existing input processing for the tree and the
list, with an additional listener to pick up any key presses while
nothing is focused.
This has two benefits:
1. Pressing a keyboard shortcut with a sidebar folder focused will
process shortcut for that node, rather than for the list selection.
2. Keyboard shortcuts will no longer activate when dialogs/buttons/input
fields are active
BUG=722300
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2885353002
Cr-Commit-Position: refs/heads/master@{#477468}
Committed: https://chromium.googlesource.com/chromium/src/+/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd
Patch Set 1 #
Total comments: 6
Patch Set 2 : Complete rewrite #
Total comments: 2
Patch Set 3 : Add a test #Messages
Total messages: 29 (21 generated)
|