chrome/browser/resources/md_bookmarks/folder_node.js - Issue 2885353002: MD Bookmarks: Prevent keyboard shortcuts when the toolbar/dialogs are focused

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_bookmarks/folder_node.js

Issue 2885353002: MD Bookmarks: Prevent keyboard shortcuts when the toolbar/dialogs are focused (Closed)

Patch Set: Add a test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/md_bookmarks/folder_node.js

diff --git a/chrome/browser/resources/md_bookmarks/folder_node.js b/chrome/browser/resources/md_bookmarks/folder_node.js

index 09dd8099ee59984910986f240fbdfa31b6a09430..f5b101e8f34eb7744d0aa13f13ad4cfef6e962be 100644

--- a/chrome/browser/resources/md_bookmarks/folder_node.js

+++ b/chrome/browser/resources/md_bookmarks/folder_node.js

@@ -110,6 +110,11 @@ Polymer({

this.changeKeyboardSelection_(

xDirection, yDirection, this.root.activeElement);

+ if (!handled) {

+ handled = bookmarks.CommandManager.getInstance().handleKeyEvent(

+ e, new Set([this.itemId]));

+ }

if (!handled)

return;