[scheduler] Fix --disable-background-timer-throttling flag.

[scheduler] Fix --disable-background-timer-throttling flag.

Make RendererScheduler respect disable-background-timer-throttling flag
when calculating policies for background renderer.

This patch also adds a test to make sure that we do not regress again.
Also scheduler simulation tests are moved to web/tests/scheduler

R=skyostil@chromium.org,alexclarke@chromium.org
BUG=722891
Review-Url: https://codereview.chromium.org/2885313003
Cr-Commit-Position: refs/heads/master@{#473217}
Committed: https://chromium.googlesource.com/chromium/src/+/bbe259ac4325ebdbce04e317b68324faabef440c

[altimin, 2017-05-17 16:25:24]

PTAL

[altimin, 2017-05-17 16:25:31]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 16:26:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 17:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:22:35]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[altimin, 2017-05-17 21:13:23]

altimin@chromium.org changed reviewers:
+ haraken@chromium.org

[altimin, 2017-05-17 21:13:24]

+haraken@, PTAL

[haraken1, 2017-05-18 07:00:25]

haraken@google.com changed reviewers:
+ haraken@google.com

[haraken1, 2017-05-18 07:00:26]

LGTM although I want to have Alex or Sami take another look.

https://codereview.chromium.org/2885313003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/scheduler/README (right):

https://codereview.chromium.org/2885313003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/scheduler/README:1: This directory contains
scheduler simulation tests.

This should be README.md.

[alex clarke (OOO till 29th), 2017-05-18 07:24:01]

LGTM % nits

https://codereview.chromium.org/2885313003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp
(right):

https://codereview.chromium.org/2885313003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp:68:
FrameThrottlingTest() : ScopedRootLayerScrollingForTest(GetParam()){};
nit: don't need a semicolon there.

[altimin, 2017-05-18 10:58:57]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 10:59:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-05-18 10:59:39]

haraken@, could you please approve from @chromium.org account?

https://codereview.chromium.org/2885313003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp
(right):

https://codereview.chromium.org/2885313003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp:68:
FrameThrottlingTest() : ScopedRootLayerScrollingForTest(GetParam()){};
On 2017/05/18 07:24:01, alex clarke wrote:
> nit: don't need a semicolon there.

Done.

https://codereview.chromium.org/2885313003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/scheduler/README (right):

https://codereview.chromium.org/2885313003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/scheduler/README:1: This directory contains
scheduler simulation tests.
On 2017/05/18 07:00:26, haraken1 wrote:
> 
> This should be README.md.

Done.

[commit-bot: I haz the power, 2017-05-18 12:10:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 12:10:21]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[haraken, 2017-05-18 14:34:59]

LGTM from a right account.

[altimin, 2017-05-18 14:44:55]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 14:45:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-05-18 14:50:46]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 14:51:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-05-18 16:05:35]

The CQ bit was unchecked by altimin@chromium.org

[altimin, 2017-05-18 16:05:36]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-05-18 16:05:36]

The CQ bit was unchecked by altimin@chromium.org

[altimin, 2017-05-18 16:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@google.com,
alexclarke@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2885313003/#ps60001
(title: "fix compilation? (again)")

[altimin, 2017-05-18 16:05:41]

The CQ bit was unchecked by altimin@chromium.org

[altimin, 2017-05-18 16:05:41]

The CQ bit was checked by altimin@chromium.org

[commit-bot: I haz the power, 2017-05-18 16:06:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 18:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:21:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[altimin, 2017-05-19 12:21:38]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 12:21:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 16:48:55]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-05-19 16:50:47]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-05-19 16:50:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, haraken@google.com, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2885313003/#ps80001
(title: "fix test crash")

[commit-bot: I haz the power, 2017-05-19 16:51:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:57:15]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495212647594150,
"parent_rev": "69a72cbed48edfe7073bd697b71e007eb72bd0d9", "commit_rev":
"8b08f4b5c08f3767fbefdb95841ae0bb05e445e2"}

[commit-bot: I haz the power, 2017-05-19 16:57:31]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495212647594150,
"parent_rev": "00096ec4e34b209ee65e48b7676dfb4f4ab6331a", "commit_rev":
"bbe259ac4325ebdbce04e317b68324faabef440c"}

[commit-bot: I haz the power, 2017-05-19 16:57:47]

Description was changed from

==========
[scheduler] Fix --disable-background-timer-throttling flag.

Make RendererScheduler respect disable-background-timer-throttling flag
when calculating policies for background renderer.

This patch also adds a test to make sure that we do not regress again.
Also scheduler simulation tests are moved to web/tests/scheduler

R=skyostil@chromium.org,alexclarke@chromium.org
BUG=722891
==========

to

==========
[scheduler] Fix --disable-background-timer-throttling flag.

Make RendererScheduler respect disable-background-timer-throttling flag
when calculating policies for background renderer.

This patch also adds a test to make sure that we do not regress again.
Also scheduler simulation tests are moved to web/tests/scheduler

R=skyostil@chromium.org,alexclarke@chromium.org
BUG=722891

Review-Url: https://codereview.chromium.org/2885313003
Cr-Commit-Position: refs/heads/master@{#473217}
Committed:
https://chromium.googlesource.com/chromium/src/+/bbe259ac4325ebdbce04e317b683...
==========

[commit-bot: I haz the power, 2017-05-19 16:57:49]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/bbe259ac4325ebdbce04e317b683...