third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp - Issue 2885313003: [scheduler] Fix --disable-background-timer-throttling flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

Issue 2885313003: [scheduler] Fix --disable-background-timer-throttling flag. (Closed)

Patch Set: fix test crash Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp ('k') | third_party/WebKit/Source/web/tests/scheduler/ActiveConnectionThrottlingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp b/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

index ecccacab6efb974bbf3402786b17733010292b7a..364f547c3423b82c45c279c334025fb47ef5d181 100644

--- a/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

@@ -15,7 +15,12 @@ namespace blink {

class MediaElementFillingViewportTest : public SimTest {

protected:

- MediaElementFillingViewportTest() { WebView().Resize(WebSize(640, 480)); }

+ MediaElementFillingViewportTest() {}

+ void SetUp() override {

+ SimTest::SetUp();

+ WebView().Resize(WebSize(640, 480));

+ }

bool IsMostlyFillingViewport(HTMLMediaElement* element) {

return element->mostly_filling_viewport_;