media: Add Media.UnderflowDuration.EME UMA

media: Add Media.UnderflowDuration.EME UMA

Encrypted media playback involves decoding in a different process and
the underflow duration could be much longer than clear media playback.
Adding this UMA to track EME-specific metrics around underflow to help
us understand the current state, and work on improvements.

BUG=721863
Review-Url: https://codereview.chromium.org/2885303002
Cr-Commit-Position: refs/heads/master@{#472575}
Committed: https://chromium.googlesource.com/chromium/src/+/68b3fab8a62e3e060690a7a0ea89fa6564b2f49f

[xhwang, 2017-05-17 04:47:27]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 04:48:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-05-17 04:51:38]

https://codereview.chromium.org/2885303002/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2885303002/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1336: // includes playbacks which never
encounter an underflow event.
What's the purpose of this logic? Are we using the "0" bucket as playback count?
We do have watchtime etc that we can use to count approximate number of
playbacks, so I wonder what's the value of this. FWIW, this makes calculating
average underflow duration etc slightly harder. ..

[xhwang, 2017-05-17 05:39:08]

xhwang@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[xhwang, 2017-05-17 05:39:08]

Please see the question. Otherwise, PTAL.

[commit-bot: I haz the power, 2017-05-17 06:26:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:26:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2017-05-17 06:31:55]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 06:33:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 09:18:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 09:18:10]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2017-05-17 20:42:41]

lgtm, per offline discussion we don't really care about the average so much as
we do how this value reacts to relative changes; thus we log zero to capture the
spectrum of underflow relative to all playbacks.

[xhwang, 2017-05-17 20:52:12]

xhwang@chromium.org changed reviewers:
+ isherman@chromium.org

[xhwang, 2017-05-17 20:52:12]

isherman: Please UMA ONWERS review!

[Ilya Sherman, 2017-05-17 21:17:07]

LGTM

[xhwang, 2017-05-17 21:19:17]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:20:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:31:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495055957741460, "parent_rev":
"eaf14a90c04606bf4aa4b3cea2fb3f6ddcf6afd8", "commit_rev":
"68b3fab8a62e3e060690a7a0ea89fa6564b2f49f"}

[commit-bot: I haz the power, 2017-05-17 21:32:05]

Description was changed from

==========
media: Add Media.UnderflowDuration.EME UMA

Encrypted media playback involves decoding in a different process and
the underflow duration could be much longer than clear media playback.
Adding this UMA to track EME-specific metrics around underflow to help
us understand the current state, and work on improvements.

BUG=721863
==========

to

==========
media: Add Media.UnderflowDuration.EME UMA

Encrypted media playback involves decoding in a different process and
the underflow duration could be much longer than clear media playback.
Adding this UMA to track EME-specific metrics around underflow to help
us understand the current state, and work on improvements.

BUG=721863

Review-Url: https://codereview.chromium.org/2885303002
Cr-Commit-Position: refs/heads/master@{#472575}
Committed:
https://chromium.googlesource.com/chromium/src/+/68b3fab8a62e3e060690a7a0ea89...
==========

[commit-bot: I haz the power, 2017-05-17 21:32:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68b3fab8a62e3e060690a7a0ea89...