media: Add Media.UnderflowDuration.EME UMA

media/blink/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <limits>
 #include <string>
@@ skipping 1315 matching lines @@
   // operations.
   if (!pipeline_controller_.IsStable())
     return;
 
   media_log_->AddEvent(media_log_->CreateBufferingStateChangedEvent(
       "pipeline_buffering_state", state));
 
   if (state == BUFFERING_HAVE_ENOUGH) {
     if (highest_ready_state_ < WebMediaPlayer::kReadyStateHaveEnoughData) {
       // Record a zero value for underflow histogram so that the histogram
       // includes playbacks which never encounter an underflow event.

[xhwang, 2017/05/17 04:51:38]

What's the purpose of this logic? Are we using the "0" bucket as playback count?
We do have watchtime etc that we can use to count approximate number of
playbacks, so I wonder what's the value of this. FWIW, this makes calculating
average underflow duration etc slightly harder. ..

       RecordUnderflowDuration(base::TimeDelta());
     }
 
     SetReadyState(CanPlayThrough() ? WebMediaPlayer::kReadyStateHaveEnoughData
                                    : WebMediaPlayer::kReadyStateHaveFutureData);
 
     // Let the DataSource know we have enough data. It may use this information
     // to release unused network connections.
     if (data_source_)
       data_source_->OnBufferingHaveEnough(false);
@@ skipping 1036 matching lines @@
   if (client_) {
     if (is_rendered_remotely)
       client_->MediaRemotingStarted();
     else
       client_->MediaRemotingStopped();
   }
 }
 
 void WebMediaPlayerImpl::RecordUnderflowDuration(base::TimeDelta duration) {
   DCHECK(data_source_ || chunk_demuxer_);
+
   if (data_source_)
     UMA_HISTOGRAM_TIMES("Media.UnderflowDuration", duration);
   else
     UMA_HISTOGRAM_TIMES("Media.UnderflowDuration.MSE", duration);
+
+  if (is_encrypted_)
+    UMA_HISTOGRAM_TIMES("Media.UnderflowDuration.EME", duration);
 }
 
 #define UMA_HISTOGRAM_VIDEO_HEIGHT(name, sample) \
   UMA_HISTOGRAM_CUSTOM_COUNTS(name, sample, 100, 10000, 50)
 
 void WebMediaPlayerImpl::RecordVideoNaturalSize(const gfx::Size& natural_size) {
   // Always report video natural size to MediaLog.
   media_log_->AddEvent(media_log_->CreateVideoSizeSetEvent(
       natural_size.width(), natural_size.height()));
 
@@ skipping 16 matching lines @@
 }
 
 #undef UMA_HISTOGRAM_VIDEO_HEIGHT
 
 void WebMediaPlayerImpl::SetTickClockForTest(base::TickClock* tick_clock) {
   tick_clock_.reset(tick_clock);
   buffered_data_source_host_.SetTickClockForTest(tick_clock);
 }
 
 }  // namespace media