Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2885293003: [step_runner] do not immediately bail when START_DIR is gone. (Closed)

Created:
3 years, 7 months ago by iannucci
Modified:
3 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[step_runner] do not immediately bail when START_DIR is gone. This is still an error in the recipe (it shouldn't ever delete the cwd... that's just a bad plan), but this should help give us some more info about where/when this happens. R=nodir@chromium.org, tandrii@chromium.org BUG=721466 Review-Url: https://codereview.chromium.org/2885293003 Committed: https://github.com/luci/recipes-py/commit/a819ab06fa3974b0fdee796aa4dd883274f4df2f

Patch Set 1 #

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -6 lines) Patch
M recipe_engine/step_runner.py View 1 1 chunk +9 lines, -1 line 0 comments Download
A recipes/engine_tests/missing_start_dir.py View 1 chunk +27 lines, -0 lines 0 comments Download
A recipes/engine_tests/missing_start_dir.expected/basic.json View 1 chunk +39 lines, -0 lines 0 comments Download
M recipes/engine_tests/step_stack_exhaustion.py View 2 chunks +2 lines, -2 lines 0 comments Download
M recipes/engine_tests/step_stack_exhaustion.expected/basic.json View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
iannucci
3 years, 7 months ago (2017-05-17 18:14:09 UTC) #1
nodir
lgtm
3 years, 7 months ago (2017-05-17 18:18:32 UTC) #6
tandrii(chromium)
lgtm
3 years, 7 months ago (2017-05-17 18:19:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885293003/20001
3 years, 7 months ago (2017-05-17 18:20:47 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 18:23:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/a819ab06fa3974b0fdee796aa4dd883274f...

Powered by Google App Engine
This is Rietveld 408576698