Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: recipes/engine_tests/step_stack_exhaustion.py

Issue 2885293003: [step_runner] do not immediately bail when START_DIR is gone. (Closed)
Patch Set: whitespace Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipes/engine_tests/step_stack_exhaustion.py
diff --git a/recipes/engine_tests/step_stack_exhaustion.py b/recipes/engine_tests/step_stack_exhaustion.py
index 1e939efaa7b96d179dc4ba4a0233f185d33ee7fd..f4f50a1f2aa17511c31af2681f0a9aad1e9d8ca8 100644
--- a/recipes/engine_tests/step_stack_exhaustion.py
+++ b/recipes/engine_tests/step_stack_exhaustion.py
@@ -2,7 +2,7 @@
# Use of this source code is governed under the Apache License, Version 2.0
# that can be found in the LICENSE file.
-"""Tests that step_data can accept multiple specs at once."""
+"""Tests that placeholders can't wreck the world by exhausting the step stack."""
from recipe_engine.util import InputPlaceholder
from recipe_engine.recipe_api import StepFailure
@@ -18,7 +18,7 @@ class BadPlaceholder(InputPlaceholder):
def RunSteps(api):
try:
- api.step('innocent step', ['echo', 'some', 'step'])
+ api.step('innocent step', ['bash', '-c', "echo some step"])
ph = BadPlaceholder('name')
ph.namespaces = ('fake', 'namespace')

Powered by Google App Engine
This is Rietveld 408576698