Move writeOutline() and writeProgram() out of KernelTarget.

Move writeOutline() and writeProgram() out of KernelTarget.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/7bc9df585e382178f6a1cb0d988f967fa875efe2

[Siggi Cherem (dart-lang), 2017-05-17 22:01:35]

lgtm, with a couple minor suggestions below

https://codereview.chromium.org/2885233003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/fasta_support.dart (right):

https://codereview.chromium.org/2885233003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/fasta_support.dart:51: if (outlineOutput != null) {
I'd remove this extra check, you don't seem to have it in some other places
anyways.

https://codereview.chromium.org/2885233003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/utils.dart (right):

https://codereview.chromium.org/2885233003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/utils.dart:30: Future<Program>
writeProgramToFileUri(Ticker ticker, Uri uri, Program program,
a couple minor suggestions: 
- rename to writeProgramToFile (no need to say to FileUri)
- reorder the args to match the order in which they are mentioned by the
function name, I think it will match users expectations more

    writeProgramToFile(program, uri, ...);


- no need to do with this CL, but it would be nice to make ticker optional as
well, even better not expect the ticker here but use the ticker only in the
context where this is called instead. In a related note I'd drop the
"isFullProgram" argument entirely as well, since it's only used for printing a
message

[scheglov, 2017-05-17 22:16:05]

https://codereview.chromium.org/2885233003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/fasta_support.dart (right):

https://codereview.chromium.org/2885233003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/fasta_support.dart:51: if (outlineOutput != null) {
On 2017/05/17 22:01:34, Siggi Cherem (dart-lang) wrote:
> I'd remove this extra check, you don't seem to have it in some other places
> anyways.

Thanks.
I was not sure that it is called in dart2js with outlineOutput always provided.

https://codereview.chromium.org/2885233003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/utils.dart (right):

https://codereview.chromium.org/2885233003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/utils.dart:30: Future<Program>
writeProgramToFileUri(Ticker ticker, Uri uri, Program program,
On 2017/05/17 22:01:35, Siggi Cherem (dart-lang) wrote:
> a couple minor suggestions: 
> - rename to writeProgramToFile (no need to say to FileUri)
> - reorder the args to match the order in which they are mentioned by the
> function name, I think it will match users expectations more
> 
>     writeProgramToFile(program, uri, ...);
> 
> 
> - no need to do with this CL, but it would be nice to make ticker optional as
> well, even better not expect the ticker here but use the ticker only in the
> context where this is called instead. In a related note I'd drop the
> "isFullProgram" argument entirely as well, since it's only used for printing a
> message

Good suggestions.
Done.

[scheglov, 2017-05-18 00:33:54]

Description was changed from

==========
Move writeOutline() and writeProgram() out of KernelTarget.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Move writeOutline() and writeProgram() out of KernelTarget.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/7bc9df585e382178f6a1cb0d988f967fa875efe2
==========

[scheglov, 2017-05-18 00:33:55]

Committed patchset #2 (id:20001) manually as
7bc9df585e382178f6a1cb0d988f967fa875efe2 (presubmit successful).