Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: pkg/front_end/lib/src/fasta/compile_platform.dart

Issue 2885233003: Move writeOutline() and writeProgram() out of KernelTarget. (Closed)
Patch Set: Fixes for review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/fasta_support.dart ('k') | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/compile_platform.dart
diff --git a/pkg/front_end/lib/src/fasta/compile_platform.dart b/pkg/front_end/lib/src/fasta/compile_platform.dart
index 2a976f2f51bc9092813467d65ef7df625fb701c4..8a67811fae046c248d4d120ba48e0d2544b5634a 100644
--- a/pkg/front_end/lib/src/fasta/compile_platform.dart
+++ b/pkg/front_end/lib/src/fasta/compile_platform.dart
@@ -76,12 +76,16 @@ Future compilePlatformInternal(CompilerContext c, Ticker ticker, Uri patchedSdk,
kernelTarget.read(Uri.parse("dart:core"));
await dillTarget.buildOutlines();
- await kernelTarget.buildOutlines();
- await kernelTarget.writeOutline(outlineOutput);
+ var outline = await kernelTarget.buildOutlines();
+
+ await writeProgramToFile(outline, outlineOutput);
+ ticker.logMs("Wrote outline to ${outlineOutput.toFilePath()}");
if (exitCode != 0) return null;
+
var program = await kernelTarget.buildProgram(verify: c.options.verify);
if (c.options.dumpIr) printProgramText(program);
- await kernelTarget.writeProgram(fullOutput);
+ await writeProgramToFile(program, fullOutput);
+ ticker.logMs("Wrote program to ${outlineOutput.toFilePath()}");
await kernelTarget.writeDepsFile(fullOutput, deps);
}
« no previous file with comments | « pkg/compiler/lib/src/kernel/fasta_support.dart ('k') | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698