Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: pkg/front_end/lib/src/fasta/fasta.dart

Issue 2885233003: Move writeOutline() and writeProgram() out of KernelTarget. (Closed)
Patch Set: Fixes for review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/fasta.dart
diff --git a/pkg/front_end/lib/src/fasta/fasta.dart b/pkg/front_end/lib/src/fasta/fasta.dart
index 8a700879f34a0ccc735d9bc1d74991ad3fef3b0b..821c7fc9b7b46807fbefd99fd58252d75944f5bd 100644
--- a/pkg/front_end/lib/src/fasta/fasta.dart
+++ b/pkg/front_end/lib/src/fasta/fasta.dart
@@ -150,7 +150,10 @@ class CompileTask {
if (c.options.dumpIr && output != null) {
printProgramText(outline);
}
- await kernelTarget.writeOutline(output);
+ if (output != null) {
+ await writeProgramToFile(outline, output);
+ ticker.logMs("Wrote outline to ${output.toFilePath()}");
+ }
return kernelTarget;
}
@@ -160,7 +163,8 @@ class CompileTask {
Uri uri = c.options.output;
var program = await kernelTarget.buildProgram(verify: c.options.verify);
if (c.options.dumpIr) printProgramText(program);
- await kernelTarget.writeProgram(uri);
+ await writeProgramToFile(program, uri);
+ ticker.logMs("Wrote program to ${uri.toFilePath()}");
return uri;
}
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/compile_platform.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698