Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2885163002: Revert of Make /deep/ as no-op and remove ::shadow in dynamic profile (Closed)

Created:
3 years, 7 months ago by rkc1
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make /deep/ as no-op and remove ::shadow in dynamic profile (patchset #9 id:160001 of https://codereview.chromium.org/2778983006/ ) Reason for revert: Completely breaks Chrome OS login UI Original issue's description: > Make /deep/ as no-op and remove ::shadow in dynamic profile > > Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns > > To make this CL small one, and easy to be reverted, all tests which depend on /deep/ > (or ::shadow) were either removed or updated in another CL: > https://bugs.chromium.org/p/chromium/issues/detail?id=715034. > > This CL only touched the small part so that users can't use /deep/ or ::shadow > in CSS dynamic profile in M60. The further internal clean up is needed in other CLs. > > BUG=489954 > > Review-Url: https://codereview.chromium.org/2778983006 > Cr-Commit-Position: refs/heads/master@{#471684} > Committed: https://chromium.googlesource.com/chromium/src/+/a7ab8a110bd6b5339c03a34a5a6bb9a419a49e60 TBR=achuith@chromium.org,alemate@chromium.org,kochi@chromium.org,hayato@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=489954

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
rkc1
Created Revert of Make /deep/ as no-op and remove ::shadow in dynamic profile
3 years, 7 months ago (2017-05-16 19:52:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885163002/1
3 years, 7 months ago (2017-05-16 19:53:36 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 19:53:38 UTC) #5
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698