[Extensions] Remove external errors on profile shutdown

chrome/browser/extensions/external_install_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_install_manager.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 50 matching lines @@
 ExternalInstallManager::ExternalInstallManager(
     content::BrowserContext* browser_context,
     bool is_first_run)
     : browser_context_(browser_context),
       is_first_run_(is_first_run),
       extension_prefs_(ExtensionPrefs::Get(browser_context_)),
       currently_visible_install_alert_(nullptr),
       extension_registry_observer_(this) {
   DCHECK(browser_context_);
   extension_registry_observer_.Add(ExtensionRegistry::Get(browser_context_));
-  registrar_.Add(
-      this,
-      extensions::NOTIFICATION_EXTENSION_REMOVED,
-      content::Source<Profile>(Profile::FromBrowserContext(browser_context_)));
+  Profile* profile = Profile::FromBrowserContext(browser_context_);
+  registrar_.Add(this, extensions::NOTIFICATION_EXTENSION_REMOVED,
+                 content::Source<Profile>(profile));
+  registrar_.Add(this, chrome::NOTIFICATION_PROFILE_DESTROYED,
+                 content::Source<Profile>(profile));
   // Populate the set of unacknowledged external extensions now. We can't just
   // rely on IsUnacknowledgedExternalExtension() for cases like
   // OnExtensionLoaded(), since we need to examine the disable reasons, which
   // can be removed throughout the session.
   for (const auto& extension :
        ExtensionRegistry::Get(browser_context)->disabled_extensions()) {
     if (IsUnacknowledgedExternalExtension(*extension))
       unacknowledged_ids_.insert(extension->id());
   }
 }
@@ skipping 154 matching lines @@
       (disable_reasons & Extension::DISABLE_EXTERNAL_EXTENSION) != 0;
   return is_disabled_external && !is_from_sideload_wipeout &&
          Manifest::IsExternalLocation(extension.location()) &&
          !extension_prefs_->IsExternalExtensionAcknowledged(extension.id());
 }
 
 void ExternalInstallManager::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
-  DCHECK_EQ(extensions::NOTIFICATION_EXTENSION_REMOVED, type);
-  // The error is invalidated if the extension has been loaded or removed.
-  // It's a shame we have to use the notification system (instead of the
-  // registry observer) for this, but the ExtensionUnloaded notification is
-  // not sent out if the extension is disabled (which it is here).
-  const std::string& extension_id =
-      content::Details<const Extension>(details).ptr()->id();
-  if (base::ContainsKey(errors_, extension_id))
-    RemoveExternalInstallError(extension_id);
+  switch (type) {
+    case extensions::NOTIFICATION_EXTENSION_REMOVED: {
+      // The error is invalidated if the extension has been loaded or removed.
+      // It's a shame we have to use the notification system (instead of the
+      // registry observer) for this, but the ExtensionUnloaded notification is
+      // not sent out if the extension is disabled (which it is here).
+      const std::string& extension_id =
+          content::Details<const Extension>(details).ptr()->id();
+      if (base::ContainsKey(errors_, extension_id))
+        RemoveExternalInstallError(extension_id);
+      break;
+    }
+    case chrome::NOTIFICATION_PROFILE_DESTROYED:
+      DCHECK_EQ(Profile::FromBrowserContext(browser_context_),
+                content::Source<const Profile>(source).ptr());
+      // Delete all errors when the profile is shutting down, before associated
+      // services are deleted.
+      errors_.clear();
+      break;
+    default:
+      NOTREACHED();
+  }
 }
 
 }  // namespace extensions