[Extensions] Remove external errors on profile shutdown

[Extensions] Remove external errors on profile shutdown

When an external error is deleted, it removes itself from the global
error service. Make sure to do this before the profile's services are
shut down by watching for the profile deleted notification.

Add a regression test.

BUG=720081
Review-Url: https://codereview.chromium.org/2885143003
Cr-Commit-Position: refs/heads/master@{#472863}
Committed: https://chromium.googlesource.com/chromium/src/+/a1c3f1a769e89d9462488f704e00dfd2b22ffdc9

[Devlin, 2017-05-16 22:55:52]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 22:57:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:25:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-05-17 00:37:35]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 00:39:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:15:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:15:07]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-05-17 15:09:13]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2017-05-17 15:09:14]

Heya Finnur, mind taking a look?

[Finnur, 2017-05-17 16:15:11]

https://codereview.chromium.org/2885143003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/external_install_error.cc (right):

https://codereview.chromium.org/2885143003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/external_install_error.cc:316: #if DCHECK_IS_ON()
Why the #if check?

[Devlin, 2017-05-17 16:17:26]

https://codereview.chromium.org/2885143003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/external_install_error.cc (right):

https://codereview.chromium.org/2885143003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/external_install_error.cc:316: #if DCHECK_IS_ON()
On 2017/05/17 16:15:11, Finnur wrote:
> Why the #if check?

Just to avoid the production cost.  Since we should be fairly confident about
this with the code + test, it didn't seem worthwhile to add the additional
overhead in release.

[Finnur, 2017-05-18 14:02:25]

LGTM

[Devlin, 2017-05-18 14:47:43]

Thanks for the review! :)

[Devlin, 2017-05-18 14:47:50]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-05-18 14:48:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 17:45:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495118870400000,
"parent_rev": "fcb1d8f15cc7b201adde93d7756ad629e83e80b3", "commit_rev":
"a1c3f1a769e89d9462488f704e00dfd2b22ffdc9"}

[commit-bot: I haz the power, 2017-05-18 17:46:01]

Description was changed from

==========
[Extensions] Remove external errors on profile shutdown

When an external error is deleted, it removes itself from the global
error service. Make sure to do this before the profile's services are
shut down by watching for the profile deleted notification.

Add a regression test.

BUG=720081
==========

to

==========
[Extensions] Remove external errors on profile shutdown

When an external error is deleted, it removes itself from the global
error service. Make sure to do this before the profile's services are
shut down by watching for the profile deleted notification.

Add a regression test.

BUG=720081

Review-Url: https://codereview.chromium.org/2885143003
Cr-Commit-Position: refs/heads/master@{#472863}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1c3f1a769e89d9462488f704e00...
==========

[commit-bot: I haz the power, 2017-05-18 17:46:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a1c3f1a769e89d9462488f704e00...