[Extensions] Remove external errors on profile shutdown

chrome/browser/extensions/external_install_error.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_install_error.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 10 matching lines @@
 #include "chrome/browser/extensions/external_install_manager.h"
 #include "chrome/browser/extensions/webstore_data_fetcher.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/global_error/global_error.h"
 #include "chrome/browser/ui/global_error/global_error_service.h"
 #include "chrome/browser/ui/global_error/global_error_service_factory.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/grit/generated_resources.h"
+#include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "content/public/browser/storage_partition.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/uninstall_reason.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_operations.h"
@@ skipping 264 matching lines @@
 
   webstore_data_fetcher_.reset(new WebstoreDataFetcher(
       this,
       content::BrowserContext::GetDefaultStoragePartition(browser_context_)->
           GetURLRequestContext(),
       GURL(), extension_id_));
   webstore_data_fetcher_->Start();
 }
 
 ExternalInstallError::~ExternalInstallError() {
+#if DCHECK_IS_ON()

[Finnur, 2017/05/17 16:15:11]

Why the #if check?

[Devlin, 2017/05/17 16:17:26]

Just to avoid the production cost.  Since we should be fairly confident about
this with the code + test, it didn't seem worthwhile to add the additional
overhead in release.

+  // Errors should only be removed while the profile is valid, since removing
+  // the error can trigger other subsystems listening for changes.
+  BrowserContextDependencyManager::GetInstance()
+      ->AssertBrowserContextWasntDestroyed(browser_context_);
+#endif
   if (global_error_.get())
     error_service_->RemoveUnownedGlobalError(global_error_.get());
 }
 
 void ExternalInstallError::OnInstallPromptDone(
     ExtensionInstallPrompt::Result result) {
   const Extension* extension = GetExtension();
 
   // If the error isn't removed and deleted as part of handling the user's
   // response (which can happen, e.g., if an uninstall fails), be sure to remove
@@ skipping 131 matching lines @@
     global_error_.reset(new ExternalInstallMenuAlert(this));
     error_service_->AddUnownedGlobalError(global_error_.get());
   }
 }
 
 void ExternalInstallError::RemoveError() {
   manager_->RemoveExternalInstallError(extension_id_);
 }
 
 }  // namespace extensions