Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2885063003: Remove ScopedComPtr::QueryFrom() (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
Reviewers:
Nico, DaleCurtis, scottmg
CC:
aboxhall+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, danakj+watch_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, feature-media-reviews_chromium.org, grt+watch_chromium.org, je_julie, mfoltz+watch_chromium.org, miu+watch_chromium.org, nektar+watch_chromium.org, pennymac+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, tfarina, toyoshim+midi_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, xjz+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedComPtr::QueryFrom() This is better expressed as calling QueryInterface() or CopyTo() directly on the incoming object. This is a mechanical refactor moving the QueryFrom() argument out and calling QueryInterface() or CopyTo() with the ScopedComPtr as the argument. BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=dalecurtis@chromium.org, thakis@chromium.org Mechanical refactor. Review-Url: https://codereview.chromium.org/2885063003 Cr-Commit-Position: refs/heads/master@{#472522} Committed: https://chromium.googlesource.com/chromium/src/+/a7956aa916bca6ef95c851e08494cdf7466b5d3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -48 lines) Patch
M base/test/test_shortcut_win.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/win/scoped_comptr.h View 1 chunk +0 lines, -7 lines 0 comments Download
M base/win/shortcut.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/win/settings_app_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/advanced_firewall_manager_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M media/midi/midi_manager_winrt.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/win/direct_manipulation.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
robliao
scottmg: Please review this change. Thanks!
3 years, 7 months ago (2017-05-16 20:10:43 UTC) #6
scottmg
lgtm
3 years, 7 months ago (2017-05-16 20:15:59 UTC) #7
robliao
TBR'ing top-level directory owners for this mechanical refactor. Owners: dalecurtis: media/* thakis: base/* chrome/* ui/*
3 years, 7 months ago (2017-05-16 22:19:23 UTC) #11
DaleCurtis
lgtm
3 years, 7 months ago (2017-05-17 01:05:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885063003/1
3 years, 7 months ago (2017-05-17 17:05:50 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 19:11:14 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7956aa916bca6ef95c851e08494...

Powered by Google App Engine
This is Rietveld 408576698