Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2885053003: [LayoutNG] Replace use of NGPhysicalFragment top/left/width/height (Closed)

Created:
3 years, 7 months ago by eae
Modified:
3 years, 7 months ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Replace use of NGPhysicalFragment top/left/width/height Replace uses of the individual Top, Left, Width, and Height accessors in NGPhysicalFragment with Offset and Size respectively to reduce API size, improve compiler enforcement of logical & physical, and reduce code size. R=ikilpatrick@chromium.org Review-Url: https://codereview.chromium.org/2885053003 Cr-Commit-Position: refs/heads/master@{#472235} Committed: https://chromium.googlesource.com/chromium/src/+/ed669ecd030559058d0aac85d75cf8945f807121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -252 lines) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 37 chunks +153 lines, -207 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 chunk +7 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_positioned_float.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
eae
3 years, 7 months ago (2017-05-16 18:46:25 UTC) #1
ikilpatrick
lgtm
3 years, 7 months ago (2017-05-16 19:50:21 UTC) #5
cbiesinger
lgtm
3 years, 7 months ago (2017-05-16 21:10:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885053003/1
3 years, 7 months ago (2017-05-16 21:50:47 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 22:50:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed669ecd030559058d0aac85d75c...

Powered by Google App Engine
This is Rietveld 408576698