Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc

Issue 2885053003: [LayoutNG] Replace use of NGPhysicalFragment top/left/width/height (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
index a5635533d1c64559a5c18a1e4d0d50881d29f27b..f9764a76ff2d866a00c45ab708dc53b04bf45d6e 100644
--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
@@ -99,9 +99,9 @@ TEST_F(NGInlineLayoutAlgorithmTest, VerticalAlignBottomReplaced) {
ToNGPhysicalBoxFragment(layout_result->PhysicalFragment().Get());
EXPECT_EQ(1u, wrapper->Children().size());
auto* line = ToNGPhysicalLineBoxFragment(wrapper->Children()[0].Get());
- EXPECT_EQ(LayoutUnit(96), line->Height());
+ EXPECT_EQ(LayoutUnit(96), line->Size().height);
auto* img = line->Children()[0].Get();
- EXPECT_EQ(LayoutUnit(0), img->TopOffset());
+ EXPECT_EQ(LayoutUnit(0), img->Offset().top);
}
// Verifies that text can flow correctly around floats that were positioned
@@ -167,18 +167,18 @@ TEST_F(NGInlineLayoutAlgorithmTest, TextFloatsAroundFloatsBefore) {
auto* text_fragment1 = text_fragments[0];
// 40 = #left-float1' width 30 + #left-float2 10
- EXPECT_EQ(LayoutUnit(40), text_fragment1->LeftOffset());
+ EXPECT_EQ(LayoutUnit(40), text_fragment1->Offset().left);
InlineTextBox* inline_text_box1 = layout_text->FirstTextBox();
EXPECT_EQ(LayoutUnit(40), inline_text_box1->X());
auto* text_fragment2 = text_fragments[1];
// 40 = #left-float1' width 30
- EXPECT_EQ(LayoutUnit(30), text_fragment2->LeftOffset());
+ EXPECT_EQ(LayoutUnit(30), text_fragment2->Offset().left);
InlineTextBox* inline_text_box2 = inline_text_box1->NextTextBox();
EXPECT_EQ(LayoutUnit(30), inline_text_box2->X());
auto* text_fragment3 = text_fragments[2];
- EXPECT_EQ(LayoutUnit(), text_fragment3->LeftOffset());
+ EXPECT_EQ(LayoutUnit(), text_fragment3->Offset().left);
InlineTextBox* inline_text_box3 = inline_text_box2->NextTextBox();
EXPECT_EQ(LayoutUnit(), inline_text_box3->X());
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698