Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2884803002: Reland of Fix ImageAnimation constant names after Blink renaming (Closed)

Created:
3 years, 7 months ago by cblume
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jzern, krit, drott+blinkwatch_chromium.org, urvang, blink-reviews-platform-graphics_chromium.org, blink-reviews-animation_chromium.org, dshwang, skal, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, shans, Rik, Justin Novosad, darktears, blink-reviews, rjwright, kinuko+watch, Eric Willigers, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix ImageAnimation constant names after Blink renaming (patchset #1 id:1 of https://codereview.chromium.org/2878363003/ ) Reason for revert: Making a patch to re-land after correcting the accidental upstream. Original issue's description: > Revert of Fix ImageAnimation constant names after Blink renaming (patchset #4 id:60001 of https://codereview.chromium.org/2857753002/ ) > > Reason for revert: > Accidentally included false dependency. > > Original issue's description: > > Fix ImageAnimation constant names after Blink renaming > > > > The ImageAnimation constants such as AnimationNone used to be named like > > cAnimationNone. This didn't match other constants within the image > > decoders. > > > > After the recent Blink style update, these were renamed like > > kCAnimationNone, making them even weirder. > > > > They should be like kAnimationNone. > > > > BUG=717669 > > > > Review-Url: https://codereview.chromium.org/2857753002 > > Cr-Commit-Position: refs/heads/master@{#471648} > > Committed: https://chromium.googlesource.com/chromium/src/+/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4 > > TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=717669 > > Review-Url: https://codereview.chromium.org/2878363003 > Cr-Commit-Position: refs/heads/master@{#471887} > Committed: https://chromium.googlesource.com/chromium/src/+/637e16339a326cac9b9065ce0645f0b4574b5093 TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717669 Review-Url: https://codereview.chromium.org/2884803002 Cr-Commit-Position: refs/heads/master@{#472116} Committed: https://chromium.googlesource.com/chromium/src/+/b7ad055459988d9431b8e67118658a4c9cc2d470

Patch Set 1 #

Patch Set 2 : Fixing accidental upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -73 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStoreTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageAnimation.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 1 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 1 9 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
cblume
Created Reland of Fix ImageAnimation constant names after Blink renaming
3 years, 7 months ago (2017-05-15 20:56:14 UTC) #1
Peter Kasting
RS LGTM
3 years, 7 months ago (2017-05-15 20:59:36 UTC) #2
scroggo_chromium
lgtm
3 years, 7 months ago (2017-05-16 13:30:09 UTC) #11
Noel Gordon
lgtm
3 years, 7 months ago (2017-05-16 13:57:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884803002/170003
3 years, 7 months ago (2017-05-16 15:53:37 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 15:54:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:170003) as
https://chromium.googlesource.com/chromium/src/+/b7ad055459988d9431b8e6711865...

Powered by Google App Engine
This is Rietveld 408576698