Created Reland of Fix ImageAnimation constant names after Blink renaming
RS LGTM
The CQ bit was checked by cblume@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by cblume@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org Link to the patchset: https://codereview.chromium.org/2884803002/#ps170003 (title: "Fixing accidental upstream")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 170003, "attempt_start_ts": 1494949978585080, "parent_rev": "bcfee609f7eb199cb27f0f67d8dbe076fc33df8a", "commit_rev": "b7ad055459988d9431b8e67118658a4c9cc2d470"}
Description was changed from ========== Reland of Fix ImageAnimation constant names after Blink renaming (patchset #1 id:1 of https://codereview.chromium.org/2878363003/ ) Reason for revert: Making a patch to re-land after correcting the accidental upstream. Original issue's description: > Revert of Fix ImageAnimation constant names after Blink renaming (patchset #4 id:60001 of https://codereview.chromium.org/2857753002/ ) > > Reason for revert: > Accidentally included false dependency. > > Original issue's description: > > Fix ImageAnimation constant names after Blink renaming > > > > The ImageAnimation constants such as AnimationNone used to be named like > > cAnimationNone. This didn't match other constants within the image > > decoders. > > > > After the recent Blink style update, these were renamed like > > kCAnimationNone, making them even weirder. > > > > They should be like kAnimationNone. > > > > BUG=717669 > > > > Review-Url: https://codereview.chromium.org/2857753002 > > Cr-Commit-Position: refs/heads/master@{#471648} > > Committed: https://chromium.googlesource.com/chromium/src/+/83bcead92eb1c2aec8bcb5e50deb... > > TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=717669 > > Review-Url: https://codereview.chromium.org/2878363003 > Cr-Commit-Position: refs/heads/master@{#471887} > Committed: https://chromium.googlesource.com/chromium/src/+/637e16339a326cac9b9065ce0645... TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717669 ========== to ========== Reland of Fix ImageAnimation constant names after Blink renaming (patchset #1 id:1 of https://codereview.chromium.org/2878363003/ ) Reason for revert: Making a patch to re-land after correcting the accidental upstream. Original issue's description: > Revert of Fix ImageAnimation constant names after Blink renaming (patchset #4 id:60001 of https://codereview.chromium.org/2857753002/ ) > > Reason for revert: > Accidentally included false dependency. > > Original issue's description: > > Fix ImageAnimation constant names after Blink renaming > > > > The ImageAnimation constants such as AnimationNone used to be named like > > cAnimationNone. This didn't match other constants within the image > > decoders. > > > > After the recent Blink style update, these were renamed like > > kCAnimationNone, making them even weirder. > > > > They should be like kAnimationNone. > > > > BUG=717669 > > > > Review-Url: https://codereview.chromium.org/2857753002 > > Cr-Commit-Position: refs/heads/master@{#471648} > > Committed: https://chromium.googlesource.com/chromium/src/+/83bcead92eb1c2aec8bcb5e50deb... > > TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=717669 > > Review-Url: https://codereview.chromium.org/2878363003 > Cr-Commit-Position: refs/heads/master@{#471887} > Committed: https://chromium.googlesource.com/chromium/src/+/637e16339a326cac9b9065ce0645... TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717669 Review-Url: https://codereview.chromium.org/2884803002 Cr-Commit-Position: refs/heads/master@{#472116} Committed: https://chromium.googlesource.com/chromium/src/+/b7ad055459988d9431b8e6711865... ==========
Committed patchset #2 (id:170003) as https://chromium.googlesource.com/chromium/src/+/b7ad055459988d9431b8e6711865...