Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2857753002: Fix ImageAnimation constant names after Blink renaming (Closed)

Created:
3 years, 7 months ago by cblume
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jzern, krit, drott+blinkwatch_chromium.org, urvang, blink-reviews-platform-graphics_chromium.org, blink-reviews-animation_chromium.org, dshwang, skal, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, shans, Rik, Justin Novosad, darktears, blink-reviews, rjwright, kinuko+watch, Eric Willigers, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ImageAnimation constant names after Blink renaming The ImageAnimation constants such as AnimationNone used to be named like cAnimationNone. This didn't match other constants within the image decoders. After the recent Blink style update, these were renamed like kCAnimationNone, making them even weirder. They should be like kAnimationNone. BUG=717669 Review-Url: https://codereview.chromium.org/2857753002 Cr-Commit-Position: refs/heads/master@{#471648} Committed: https://chromium.googlesource.com/chromium/src/+/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebasing #

Patch Set 4 : Fix incorrect dependent CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -78 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStoreTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageAnimation.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 1 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 1 9 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 27 (16 generated)
cblume
PTAL
3 years, 7 months ago (2017-05-02 20:41:08 UTC) #4
Noel Gordon
LGTM.
3 years, 7 months ago (2017-05-03 00:14:34 UTC) #7
Peter Kasting
RS LGTM
3 years, 7 months ago (2017-05-05 00:26:19 UTC) #8
cblume
On 2017/05/05 00:26:19, Peter Kasting wrote: > RS LGTM What is the "RS" in "RS ...
3 years, 7 months ago (2017-05-08 20:12:31 UTC) #9
pdr.
On 2017/05/08 at 20:12:31, cblume wrote: > On 2017/05/05 00:26:19, Peter Kasting wrote: > > ...
3 years, 7 months ago (2017-05-08 20:14:55 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2880533002 Patch 20001). Please resolve the dependency and ...
3 years, 7 months ago (2017-05-14 23:13:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857753002/60001
3 years, 7 months ago (2017-05-14 23:44:25 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4
3 years, 7 months ago (2017-05-15 01:41:28 UTC) #24
scroggo_chromium
Hey, you didn't properly fix the dependency. You pulled your dependency into this one, and ...
3 years, 7 months ago (2017-05-15 12:32:19 UTC) #25
cblume
On 2017/05/15 12:32:19, scroggo_chromium wrote: > Hey, you didn't properly fix the dependency. You pulled ...
3 years, 7 months ago (2017-05-15 17:07:11 UTC) #26
cblume
3 years, 7 months ago (2017-05-15 17:08:18 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2878363003/ by cblume@chromium.org.

The reason for reverting is: Accidentally included false dependency..

Powered by Google App Engine
This is Rietveld 408576698