Automated IWYU fix for TaskRunner includes.

Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n *[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner\b(>&|\*)?)', re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2884763002 .
Cr-Commit-Position: refs/heads/master@{#472157}
Committed: https://chromium.googlesource.com/chromium/src/+/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec

[gab, 2017-05-15 18:41:30]

Description was changed from

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
==========

to

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-15 18:41:32]

Description was changed from

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-15 18:43:28]

Description was changed from

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in
https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just
fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=fdoray@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-15 18:43:30]

gab@chromium.org changed reviewers:
+ fdoray@chromium.org

[gab, 2017-05-15 19:19:37]

Description was changed from

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in
https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just
fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=fdoray@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in
https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just
fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner\b(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=fdoray@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-15 19:21:26]

Description was changed from

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in
https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just
fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner\b(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=fdoray@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in
https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just
fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner\b(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-15 19:22:03]

fdoray@ PTaL, will TBR self to bypass other owners

[gab, 2017-05-15 20:16:22]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 20:17:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 20:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 20:26:40]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2017-05-15 20:59:33]

On 2017/05/15 19:22:03, gab wrote:
> fdoray@ PTaL, will TBR self to bypass other owners

Need to land quick as the target files move and create conflict fast, will land
now, please review when you have time and I'm happy to address anything you spot
in a follow-up.

[gab, 2017-05-15 21:01:35]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:04:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 21:12:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:12:52]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2017-05-16 14:26:18]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-16 14:26:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 17:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 17:23:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2017-05-16 18:00:44]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:03:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-16 18:03:36]

On 2017/05/16 17:23:56, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Not at fault, landing manually to avoid another patch failure as more CLs land
on trunk.

[gab, 2017-05-16 18:06:13]

Description was changed from

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in
https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just
fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner\b(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in
https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just
fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n
*[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner\b(>&|\*)?)',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content,
"base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2884763002 .
Cr-Commit-Position: refs/heads/master@{#472157}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ff87ceb5f871cfd111b0d057eaf...
==========

[gab, 2017-05-16 18:06:18]

Committed patchset #4 (id:60001) manually as
5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec (presubmit successful).