Remove unused include in sequenced_worker_pool.h

Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):
  kmarshall@: blimp/
  danakj@: cc/
           storage/
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/

Committed: https://crrev.com/10ae436fe808a33451641e3b92e10f20954e28dc
Cr-Commit-Position: refs/heads/master@{#429451}

[gab, 2016-10-24 14:44:27]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 14:44:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-10-24 14:45:15]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2016-10-24 14:45:16]

Dana PTAL and CQ, thanks!

[commit-bot: I haz the power, 2016-10-24 15:02:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 15:02:40]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[gab, 2016-10-24 15:10:34]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 15:10:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-10-24 15:33:25]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 15:33:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-10-24 15:37:38]

The CQ bit was unchecked by gab@chromium.org

[gab, 2016-10-24 15:38:12]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2016-10-24 15:38:22]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-10-24 15:38:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 15:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 15:49:13]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gab, 2016-10-24 16:23:29]

On 2016/10/24 14:45:16, gab wrote:
> Dana PTAL and CQ, thanks!

Actually wait, IWUU is way messed up all over the place... Just realized that
our recommendation to pass scoped_refptr<T> by value (to take advantage of move)
also forces headers to define T as ref_counted.h doesn't merely move pointers,
it does AddRef/Release and the ref is held on the underlying type so T needs to
be defined...

Maybe there's a way to change ref_counted.h so that T is validated to be a
subclass of RefCounted (e.g. via std::enable_if) and then stored as such so that
peoples that merely do moves/AddRef/Release don't need the full type -- just
like std::unique_ptr).

WDYT?

[danakj, 2016-10-24 18:40:42]

On 2016/10/24 16:23:29, gab wrote:
> On 2016/10/24 14:45:16, gab wrote:
> > Dana PTAL and CQ, thanks!
> 
> Actually wait, IWUU is way messed up all over the place... Just realized that
> our recommendation to pass scoped_refptr<T> by value (to take advantage of
move)
> also forces headers to define T as ref_counted.h doesn't merely move pointers,
> it does AddRef/Release and the ref is held on the underlying type so T needs
to
> be defined...
> 
> Maybe there's a way to change ref_counted.h so that T is validated to be a
> subclass of RefCounted (e.g. via std::enable_if) and then stored as such so
that
> peoples that merely do moves/AddRef/Release don't need the full type -- just
> like std::unique_ptr).
> 
> WDYT?

I like that idea.

[gab, 2016-10-24 18:52:05]

Description was changed from

==========
Remove unused include in sequenced_worker_pool.h

Breaks a cyclic dependency in an upcoming CL of mine.

BUG=653916
==========

to

==========
Remove unused include in sequenced_worker_pool.h

Breaks a cyclic dependency in an upcoming CL of mine.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[gab, 2016-10-24 18:52:08]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 18:52:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:16:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[gab, 2016-10-27 13:57:04]

Patchset #5 (id:100001) has been deleted

[gab, 2016-10-28 20:12:47]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 20:13:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 20:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 20:17:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-10-28 20:26:53]

Description was changed from

==========
Remove unused include in sequenced_worker_pool.h

Breaks a cyclic dependency in an upcoming CL of mine.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWUU
all over the place!

The trickiest IWUU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWUU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[gab, 2016-10-28 20:29:40]

On 2016/10/24 18:40:42, danakj wrote:
> On 2016/10/24 16:23:29, gab wrote:
> > On 2016/10/24 14:45:16, gab wrote:
> > > Dana PTAL and CQ, thanks!
> > 
> > Actually wait, IWUU is way messed up all over the place... Just realized
that
> > our recommendation to pass scoped_refptr<T> by value (to take advantage of
> move)
> > also forces headers to define T as ref_counted.h doesn't merely move
pointers,
> > it does AddRef/Release and the ref is held on the underlying type so T needs
> to
> > be defined...
> > 
> > Maybe there's a way to change ref_counted.h so that T is validated to be a
> > subclass of RefCounted (e.g. via std::enable_if) and then stored as such so
> that
> > peoples that merely do moves/AddRef/Release don't need the full type -- just
> > like std::unique_ptr).
> > 
> > WDYT?
> 
> I like that idea.

I didn't manage to do this, I'll send a PSA to chromium-dev about what I
discovered after this lands (for now summarized in this CL's description).

The only way to get this done AFAICT would be to define the static
scoped_refptr<T>::AddRef/Release methods out-of-line which would be a
performance hit that is unlikely to be worth it to save include pain.

PTAnL, let me know whether I should find owners for side-effects or just TBR
them based on your review.

Thanks,
Gab

[gab, 2016-10-28 20:30:11]

Inline notes:

https://codereview.chromium.org/2443103003/diff/120001/base/threading/sequenc...
File base/threading/sequenced_worker_pool.h (right):

https://codereview.chromium.org/2443103003/diff/120001/base/threading/sequenc...
base/threading/sequenced_worker_pool.h:233: SequenceToken token)
WARN_UNUSED_RESULT;
By the IWUU described in description this would have required #include
"sequenced_task_runner.h" which defeats the purpose of what I'm trying to
achieve in this CL (break a dependency cycle involving sequenced_task_runner.h).

The reason IWUU dictates that a return by value must be fully defined by the API
providing it is so that the caller doesn't need include things for return values
it ignores. In this case it doesn't make sense to ignore these return values and
as such I think this is okay.

https://codereview.chromium.org/2443103003/diff/120001/storage/browser/blob/b...
File storage/browser/blob/blob_data_handle.h (right):

https://codereview.chromium.org/2443103003/diff/120001/storage/browser/blob/b...
storage/browser/blob/blob_data_handle.h:51: BlobDataHandle& operator=(const
BlobDataHandle& other);
This is required as otherwise it is implicitly inlined which requires the
scoped_refptr to be fully defined in the header (or we could DISALLOW_ASSIGN but
style guide says to provide matching constructor/assignment operators).

[gab, 2016-10-28 20:32:23]

One more note, don't worry about the red bots, will rebase on Monday but it
compiles locally with clang.

https://codereview.chromium.org/2443103003/diff/120001/components/gcm_driver/...
File components/gcm_driver/fake_gcm_driver.cc (right):

https://codereview.chromium.org/2443103003/diff/120001/components/gcm_driver/...
components/gcm_driver/fake_gcm_driver.cc:12: FakeGCMDriver::FakeGCMDriver() :
GCMDriver(base::FilePath(), nullptr) {
The include above is tricky as initially the const
scoped_refptr<base::SequencedTaskRunner>& leads to believe it's not required...

But it is for this line as the nullptr results in a temporary inline
scoped_refptr<base::SequencedTaskRunner> which thus needs to instantiate the
template.

[danakj, 2016-10-29 00:01:28]

LGTM tho aren't you going to make scoped_refptr<T> not require including t.h?

https://codereview.chromium.org/2443103003/diff/120001/base/threading/sequenc...
File base/threading/sequenced_worker_pool.h (right):

https://codereview.chromium.org/2443103003/diff/120001/base/threading/sequenc...
base/threading/sequenced_worker_pool.h:233: SequenceToken token)
WARN_UNUSED_RESULT;
On 2016/10/28 20:30:11, gab wrote:
> By the IWUU described in description this would have required #include
> "sequenced_task_runner.h" which defeats the purpose of what I'm trying to
> achieve in this CL (break a dependency cycle involving
sequenced_task_runner.h).
> 
> The reason IWUU dictates that a return by value must be fully defined by the
API
> providing it is so that the caller doesn't need include things for return
values
> it ignores. In this case it doesn't make sense to ignore these return values
and
> as such I think this is okay.

It's going to maybe bite us if we ever get auto iwyu, but then what isn't?

[gab, 2016-10-31 15:20:05]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 15:20:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-10-31 15:23:52]

On 2016/10/29 00:01:28, danakj wrote:
> LGTM tho aren't you going to make scoped_refptr<T> not require including t.h?

No, I didn't manage to, I'll post something to chromium-dev after this CL lands
explaining the new required IWUU paradigm for scoped_refptr<T> as well as why I
couldn't make it work.

[gab, 2016-10-31 15:38:00]

gab@chromium.org changed reviewers:
+ agl@chromium.org, bengr@chromium.org, csharrison@chromium.org,
dalecurtis@chromium.org, dglazkov@chromium.org, dgozman@chromium.org,
dimich@chromium.org, erg@chromium.org, garykac@chromium.org, gene@chromium.org,
hbos@chromium.org, jsbell@chromium.org, kbr@chromium.org, mef@chromium.org,
michaeln@chromium.org, mkwst@chromium.org, pfeldman@chromium.org,
rockot@chromium.org

[gab, 2016-10-31 15:38:00]

TBR reviewers for IWUU side-effects (and minor other touchups):

  danakj@: cc/
  gene@: chrome/service/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  jsbell@: storage/
  dglazkov@: third_party/WebKit/Source/platform/

[commit-bot: I haz the power, 2016-10-31 15:40:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:40:16]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[gab, 2016-10-31 15:41:09]

gab@chromium.org changed reviewers:
+ maxbogue@chromium.org
- jsbell@chromium.org

[gab, 2016-10-31 15:41:10]

Slight tweaks to reviewer list [-jsbell@, +maxbogue@]:

TBR reviewers for IWUU side-effects (and minor other touchups):

  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/

[mef, 2016-10-31 15:44:52]

components/wifi lgtm

[gab, 2016-10-31 15:50:44]

The CQ bit was checked by gab@chromium.org

[gab, 2016-10-31 15:50:45]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
mef@chromium.org
Link to the patchset: https://codereview.chromium.org/2443103003/#ps160001
(title: "fix post merge compile")

[commit-bot: I haz the power, 2016-10-31 15:51:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:51:07]

This CL has an open dependency (Issue 2446403006 Patch 60001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[gab, 2016-10-31 15:51:39]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWUU
all over the place!

The trickiest IWUU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWUU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWUU
all over the place!

The trickiest IWUU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWUU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

[gab, 2016-10-31 15:51:55]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:52:07]

This CL has an open dependency (Issue 2446403006 Patch 60001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[gab, 2016-10-31 16:06:41]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 16:07:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 16:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 16:21:19]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[gab, 2016-10-31 16:50:02]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWUU
all over the place!

The trickiest IWUU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWUU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

[gab, 2016-10-31 17:42:27]

gab@chromium.org changed reviewers:
+ kmarshall@chromium.org, rsesek@chromium.org

[gab, 2016-10-31 17:42:28]

TBR reviewers for IWUU side-effects (and minor other touchups):

  + kmarshall@: blimp/
  + rsesek@: components/upload_list/

  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/

[gab, 2016-10-31 17:43:38]

The CQ bit was checked by gab@chromium.org

[gab, 2016-10-31 17:43:39]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2443103003/#ps180001
(title: "more IWYU fixes")

[commit-bot: I haz the power, 2016-10-31 17:44:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 18:02:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:02:15]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[gab, 2016-10-31 18:27:23]

The CQ bit was checked by gab@chromium.org

[gab, 2016-10-31 18:27:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2443103003/#ps200001
(title: "and more android/ios/cros")

[commit-bot: I haz the power, 2016-10-31 18:27:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-10-31 18:28:12]

The CQ bit was unchecked by gab@chromium.org

[gab, 2016-10-31 18:28:58]

The CQ bit was checked by gab@chromium.org

[gab, 2016-10-31 18:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2443103003/#ps220001
(title: "and more: win")

[commit-bot: I haz the power, 2016-10-31 18:29:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-10-31 18:32:13]

gab@chromium.org changed reviewers:
+ achuith@chromium.org, bradnelson@chromium.org, droger@chromium.org

[gab, 2016-10-31 18:32:14]

TBR reviewers for IWUU side-effects (and minor other touchups):

  + droger@: ios/
  + bradnelson@: components/nacl/
  + achuith@: components/pairing/
  
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  rsesek@: components/upload_list/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/

Done (thanks!):
  mef@: components/wifi/

[gab, 2016-10-31 18:33:13]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

[Robert Sesek, 2016-10-31 18:33:17]

Just a nit, but lgtm

https://codereview.chromium.org/2443103003/diff/220001/components/upload_list...
File components/upload_list/crash_upload_list.h (right):

https://codereview.chromium.org/2443103003/diff/220001/components/upload_list...
components/upload_list/crash_upload_list.h:10: #include "base/task_runner.h"
This has a fwd declare on line 15, so maybe this is better in the .cc?

[gab, 2016-10-31 18:35:09]

The CQ bit was checked by gab@chromium.org

[gab, 2016-10-31 18:35:11]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
danakj@chromium.org, rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2443103003/#ps240001
(title: "nit")

[gab, 2016-10-31 18:35:18]

https://codereview.chromium.org/2443103003/diff/220001/components/upload_list...
File components/upload_list/crash_upload_list.h (right):

https://codereview.chromium.org/2443103003/diff/220001/components/upload_list...
components/upload_list/crash_upload_list.h:10: #include "base/task_runner.h"
On 2016/10/31 18:33:17, Robert Sesek wrote:
> This has a fwd declare on line 15, so maybe this is better in the .cc?

Oops indeed, removed fwd-decl (see CL description, fwd-decl is insufficient here
sadly).

[commit-bot: I haz the power, 2016-10-31 18:35:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 19:01:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:01:18]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[gab, 2016-10-31 19:25:55]

gab@chromium.org changed reviewers:
+ fukino@chromium.org

[gab, 2016-10-31 19:25:56]

TBR reviewers for IWUU side-effects (and minor other touchups):

  + fukino: components/drive/ (PS: this component also incorrectly uses raw ptrs
to pass references, it should use scoped_refptr arguments not raw * arguments
when passing references, out of scope for this CL, leaving this up for you to
fix)

  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/

Done (thanks!):
  rsesek@: components/upload_list/
  mef@: components/wifi/

[gab, 2016-10-31 19:26:19]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

[gab, 2016-10-31 19:27:13]

The CQ bit was checked by gab@chromium.org

[gab, 2016-10-31 19:27:14]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
danakj@chromium.org, rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2443103003/#ps260001
(title: "and more ios/chromeos")

[commit-bot: I haz the power, 2016-10-31 19:27:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:20:42]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[michaeln, 2016-10-31 20:51:59]

r/s lgtm

[Kevin M, 2016-10-31 22:52:04]

blimp lgtm

[Ken Russell (switch to Gerrit), 2016-11-01 02:36:09]

gpu lgtm

[Charlie Harrison, 2016-11-01 02:53:35]

https://codereview.chromium.org/2443103003/diff/260001/content/browser/loader...
File content/browser/loader/upload_data_stream_builder.cc (right):

https://codereview.chromium.org/2443103003/diff/260001/content/browser/loader...
content/browser/loader/upload_data_stream_builder.cc:17: #include
"base/single_thread_task_runner.h"
I'm not sure why this can't be a fwd-decl. There's no use of
scoped_refptr<SingleThreadTaskRunner> in the header.

[hbos_chromium, 2016-11-01 08:47:17]

content/renderer/media/ lgtm

[gab, 2016-11-01 13:22:26]

The CQ bit was checked by gab@chromium.org

[gab, 2016-11-01 13:22:27]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
mef@chromium.org, danakj@chromium.org, rsesek@chromium.org, hbos@chromium.org,
kmarshall@chromium.org, michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2443103003/#ps280001
(title: "more chromeos")

[commit-bot: I haz the power, 2016-11-01 13:22:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-11-01 13:30:59]

@csharrison

https://codereview.chromium.org/2443103003/diff/260001/content/browser/loader...
File content/browser/loader/upload_data_stream_builder.cc (right):

https://codereview.chromium.org/2443103003/diff/260001/content/browser/loader...
content/browser/loader/upload_data_stream_builder.cc:17: #include
"base/single_thread_task_runner.h"
On 2016/11/01 02:53:35, Charlie Harrison wrote:
> I'm not sure why this can't be a fwd-decl. There's no use of
> scoped_refptr<SingleThreadTaskRunner> in the header.

It's subtle but there is, in UploadDataStreamBuilder::Build():
|file_task_runner| is passed into FileElementReader's constructor. The former is
a SingleThreadTaskRunner* while the latter takes a TaskRunner* as argument. In
order to perform the implicit upcast, the compiler has to know that
SingleThreadTaskRunner implements TaskRunner.

[Charlie Harrison, 2016-11-01 13:34:53]

lgtm thanks for the explanation.

[gab, 2016-11-01 13:37:46]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  danakj@: cc/
           storage/ [-jsbell@]
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

[gab, 2016-11-01 13:42:03]

TBR reviewers for IWUU side-effects (and minor other touchups):

  + bartfab@: chrome/browser/chromeos/policy/

  danakj@: cc/
           storage/ [-jsbell@]
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/ (PS: this component also incorrectly uses raw ptrs
to pass references, it should use scoped_refptr arguments not raw * arguments
when passing references, out of scope for this CL, leaving this up for you to
fix)
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  dgozman@: content/browser/devtools/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/

Done (thanks!):
  kmarshall: blimp/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  kbr@: gpu/

[gab, 2016-11-01 13:42:40]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  danakj@: cc/
           storage/ [-jsbell@]
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  kmarshall@: blimp/
  danakj@: cc/
           storage/ [-jsbell@]
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

[gab, 2016-11-01 13:42:53]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  kmarshall@: blimp/
  danakj@: cc/
           storage/ [-jsbell@]
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  kmarshall@: blimp/
  danakj@: cc/
           storage/
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

[agl, 2016-11-01 15:26:08]

lgtm

[maxbogue, 2016-11-01 16:25:53]

sync lgtm

[commit-bot: I haz the power, 2016-11-01 17:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 17:24:03]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2016-11-01 20:44:30]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-11-01 20:45:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 00:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 00:48:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2016-11-02 13:26:37]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-11-02 13:26:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 17:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:04:29]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[gab, 2016-11-02 17:40:43]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:41:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 17:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:50:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[gab, 2016-11-02 18:05:24]

The CQ bit was checked by gab@chromium.org

[gab, 2016-11-02 18:05:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
csharrison@chromium.org, mef@chromium.org, danakj@chromium.org,
rsesek@chromium.org, maxbogue@chromium.org, hbos@chromium.org,
kmarshall@chromium.org, michaeln@chromium.org, agl@chromium.org
Link to the patchset: https://codereview.chromium.org/2443103003/#ps300001
(title: "merge up to r429325")

[commit-bot: I haz the power, 2016-11-02 18:05:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 20:07:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 20:07:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-11-02 20:11:05]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-11-02 20:11:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 23:35:25]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  kmarshall@: blimp/
  danakj@: cc/
           storage/
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  kmarshall@: blimp/
  danakj@: cc/
           storage/
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

[commit-bot: I haz the power, 2016-11-02 23:35:27]

Committed patchset #14 (id:300001)

[commit-bot: I haz the power, 2016-11-02 23:37:58]

Description was changed from

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):  
  kmarshall@: blimp/
  danakj@: cc/
           storage/
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/
==========

to

==========
Remove dependency of sequenced_worker_pool.h on SingleThreadTaskRunner.

Breaks a cyclic dependency in an upcoming CL of mine.

Removing the include of single_thread_task_runner.h here breaks IWYU
all over the place!

The trickiest IWYU thing being exposed by this is that in order for
scoped_refptr<Foo> to be instantiated (not even used), Foo needs to be
fully defined.

This means that, by IWYU, anyone taking a scoped_refptr<Foo> by value or
returning one by value needs to #include "foo.h".

It's still fine to fwd-decl foo when passing via const scoped_refptr<Foo>&
or having a scoped_refptr<Foo> foo_; member in a class constructed/destroyed
out-of-line.

BUG=653916
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reviewers for IWUU side-effects (and minor other touchups):
  kmarshall@: blimp/
  danakj@: cc/
           storage/
  bartfab@: chrome/browser/chromeos/policy/
  gene@: chrome/service/
  maxbogue@: components/browser_sync/
             components/sync/
  bengr@: components/data_reduction_proxy/
  fukino@: components/drive/
  dimich@: components/gcm_driver/
  bradnelson@: components/nacl/
  achuith@: components/pairing/
  rsesek@: components/upload_list/
  mef@: components/wifi/
  michaeln@: content/browser/cache_storage/
             content/child/fileapi/
  dgozman@: content/browser/devtools/
  csharrison@: content/browser/loader/
  hbos@: content/renderer/media/
  mkwst@: content/shell/
  pfeldman@: device/usb/
  kbr@: gpu/
  droger@: ios/
  rockot@: ipc/
  dalecurtis@: media/
  agl@: net/
  garykac@: remoting/
  erg@: services/ui/
  dglazkov@: third_party/WebKit/Source/platform/

Committed: https://crrev.com/10ae436fe808a33451641e3b92e10f20954e28dc
Cr-Commit-Position: refs/heads/master@{#429451}
==========

[commit-bot: I haz the power, 2016-11-02 23:37:59]

Patchset 14 (id:??) landed as
https://crrev.com/10ae436fe808a33451641e3b92e10f20954e28dc
Cr-Commit-Position: refs/heads/master@{#429451}