chrome/browser/ui/cocoa/notifications/xpc-Info.plist - Issue 2884693002: Rename the XPC identifier to use the outer bundle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/notifications/xpc-Info.plist

Issue 2884693002: Rename the XPC identifier to use the outer bundle (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/notifications/xpc-Info.plist

diff --git a/chrome/browser/ui/cocoa/notifications/xpc-Info.plist b/chrome/browser/ui/cocoa/notifications/xpc-Info.plist

index cd0123eebea0ea7584c67751f076a4c7e26adee2..22825da263e2168abfe9eddd8ef07d7cd7e98513 100644

--- a/chrome/browser/ui/cocoa/notifications/xpc-Info.plist

+++ b/chrome/browser/ui/cocoa/notifications/xpc-Info.plist

@@ -9,7 +9,7 @@

<key>CFBundleExecutable</key>

<string>${EXECUTABLE_NAME}</string>

<key>CFBundleIdentifier</key>

- <string>${CHROME_BUNDLE_ID}.framework.${EXECUTABLE_NAME}</string>

+ <string>${CHROME_BUNDLE_ID}.${EXECUTABLE_NAME}</string>

Mark Mentovai 2017/05/16 18:20:08 Since it’s living in the framework, I think we sho

Miguel Garcia 2017/05/19 08:43:56 Done.

<key>CFBundleInfoDictionaryVersion</key>

<key>CFBundleName</key>