chrome/browser/ui/cocoa/notifications/xpc-Info.plist - Issue 2884693002: Rename the XPC identifier to use the outer bundle

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/notifications/xpc-Info.plist

Issue 2884693002: Rename the XPC identifier to use the outer bundle (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/notifications/notification_platform_bridge_mac.mm ('k') | chrome/installer/mac/sign_versioned_dir.sh.in » ('j') | chrome/installer/mac/sign_versioned_dir.sh.in » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">

3 <plist version="1.0">	3 <plist version="1.0">

4 <dict>	4 <dict>

5 <key>CFBundleDevelopmentRegion</key>	5 <key>CFBundleDevelopmentRegion</key>

6 <string>en</string>	6 <string>en</string>

7 <key>CFBundleDisplayName</key>	7 <key>CFBundleDisplayName</key>

8 <string>${EXECUTABLE_NAME}</string>	8 <string>${EXECUTABLE_NAME}</string>

9 <key>CFBundleExecutable</key>	9 <key>CFBundleExecutable</key>

10 <string>${EXECUTABLE_NAME}</string>	10 <string>${EXECUTABLE_NAME}</string>

11 <key>CFBundleIdentifier</key>	11 <key>CFBundleIdentifier</key>

12 <string>${CHROME_BUNDLE_ID}.framework.${EXECUTABLE_NAME}</string>	12 <string>${CHROME_BUNDLE_ID}.${EXECUTABLE_NAME}</string>
	Mark Mentovai 2017/05/16 18:20:08 Since it’s living in the framework, I think we sho Since it’s living in the framework, I think we should keep the .framework. Miguel Garcia 2017/05/19 08:43:56 Done. Show quoted text On 2017/05/16 18:20:08, Mark Mentovai wrote: > Since it’s living in the framework, I think we should keep the .framework. Done.
13 <key>CFBundleInfoDictionaryVersion</key>	13 <key>CFBundleInfoDictionaryVersion</key>

14 <string>6.0</string>	14 <string>6.0</string>

15 <key>CFBundleName</key>	15 <key>CFBundleName</key>

16 <string>${EXECUTABLE_NAME}</string>	16 <string>${EXECUTABLE_NAME}</string>

17 <key>CFBundlePackageType</key>	17 <key>CFBundlePackageType</key>

18 <string>XPC!</string>	18 <string>XPC!</string>

19 <key>CFBundleShortVersionString</key>	19 <key>CFBundleShortVersionString</key>

20 <string>1.0</string>	20 <string>1.0</string>

21 <key>CFBundleSignature</key>	21 <key>CFBundleSignature</key>

22 <string>????</string>	22 <string>????</string>

23 <key>CFBundleVersion</key>	23 <key>CFBundleVersion</key>

24 <string>1</string>	24 <string>1</string>

25 <key>XPCService</key>	25 <key>XPCService</key>

26 <dict>	26 <dict>

27 <key>ServiceType</key>	27 <key>ServiceType</key>

28 <string>Application</string>	28 <string>Application</string>

29 </dict>	29 </dict>

30 <key>NSUserNotificationAlertStyle</key>	30 <key>NSUserNotificationAlertStyle</key>

31 <string>alert</string>	31 <string>alert</string>

32 </dict>	32 </dict>

33 </plist>	33 </plist>

OLD	NEW