chrome/installer/mac/sign_versioned_dir.sh.in - Issue 2884693002: Rename the XPC identifier to use the outer bundle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/sign_versioned_dir.sh.in

Issue 2884693002: Rename the XPC identifier to use the outer bundle (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mac/sign_versioned_dir.sh.in

diff --git a/chrome/installer/mac/sign_versioned_dir.sh.in b/chrome/installer/mac/sign_versioned_dir.sh.in

index 4e5640b8b0d830c2aeff73f3ead6d1ba2f332d26..aa9ad17e7cbbc75d48fb53e57f799d31b58e82c9 100644

--- a/chrome/installer/mac/sign_versioned_dir.sh.in

+++ b/chrome/installer/mac/sign_versioned_dir.sh.in

@@ -114,7 +114,7 @@ rm -f "${app_mode_loader_tmp}"

codesign_with_options "${notification_service}" \

"${enforcement_flags_helpers}" \

- "com.google.Chrome.framework.AlertNotificationService"

+ "com.google.Chrome.AlertNotificationService"

Mark Mentovai 2017/05/16 18:20:08 Here too.

Miguel Garcia 2017/05/19 08:43:56 Done.

# Only sign widevine plugin if it is present in the bundle.

# ${enforcement_flags*} are meaningless for dynamic libraries.