Rename the XPC identifier to use the outer bundle

Rename the XPC identifier to use the outer bundle

This is essentially a manual revert of
https://codereview.chromium.org/2727003002 to provide XPC
servers from different channels with a unique name.

BUG=720776
Review-Url: https://codereview.chromium.org/2884693002
Cr-Commit-Position: refs/heads/master@{#473538}
Committed: https://chromium.googlesource.com/chromium/src/+/44554d6a63cde5ea96c5d315176d7cf45222e1d6

[Miguel Garcia, 2017-05-16 09:15:42]

miguelg@chromium.org changed reviewers:
+ mark@chromium.org, rsesek@chromium.org

[Mark Mentovai, 2017-05-16 18:20:08]

This means that your other change will need a tweak to include the .framework
too, I suppose.

https://codereview.chromium.org/2884693002/diff/1/chrome/browser/ui/cocoa/not...
File chrome/browser/ui/cocoa/notifications/xpc-Info.plist (right):

https://codereview.chromium.org/2884693002/diff/1/chrome/browser/ui/cocoa/not...
chrome/browser/ui/cocoa/notifications/xpc-Info.plist:12:
<string>${CHROME_BUNDLE_ID}.${EXECUTABLE_NAME}</string>
Since it’s living in the framework, I think we should keep the .framework.

https://codereview.chromium.org/2884693002/diff/1/chrome/installer/mac/sign_v...
File chrome/installer/mac/sign_versioned_dir.sh.in (right):

https://codereview.chromium.org/2884693002/diff/1/chrome/installer/mac/sign_v...
chrome/installer/mac/sign_versioned_dir.sh.in:117:
"com.google.Chrome.AlertNotificationService"
Here too.

[Miguel Garcia, 2017-05-19 08:43:57]

Updated both CLs to include "framework" in the identifier's name

https://codereview.chromium.org/2884693002/diff/1/chrome/browser/ui/cocoa/not...
File chrome/browser/ui/cocoa/notifications/xpc-Info.plist (right):

https://codereview.chromium.org/2884693002/diff/1/chrome/browser/ui/cocoa/not...
chrome/browser/ui/cocoa/notifications/xpc-Info.plist:12:
<string>${CHROME_BUNDLE_ID}.${EXECUTABLE_NAME}</string>
On 2017/05/16 18:20:08, Mark Mentovai wrote:
> Since it’s living in the framework, I think we should keep the .framework.

Done.

https://codereview.chromium.org/2884693002/diff/1/chrome/installer/mac/sign_v...
File chrome/installer/mac/sign_versioned_dir.sh.in (right):

https://codereview.chromium.org/2884693002/diff/1/chrome/installer/mac/sign_v...
chrome/installer/mac/sign_versioned_dir.sh.in:117:
"com.google.Chrome.AlertNotificationService"
On 2017/05/16 18:20:08, Mark Mentovai wrote:
> Here too.

Done.

[Mark Mentovai, 2017-05-19 17:06:43]

LGTM

[Miguel Garcia, 2017-05-22 09:49:02]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2017-05-22 09:49:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 10:11:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495446542173820,
"parent_rev": "699d393fc495fa1e835d7d72a4f308d55ffc80b2", "commit_rev":
"44554d6a63cde5ea96c5d315176d7cf45222e1d6"}

[commit-bot: I haz the power, 2017-05-22 10:12:03]

Description was changed from

==========
Rename the XPC identifier to use the outer bundle

This is essentially a manual revert of
https://codereview.chromium.org/2727003002 to provide XPC
servers from different channels with a unique name.

BUG=720776
==========

to

==========
Rename the XPC identifier to use the outer bundle

This is essentially a manual revert of
https://codereview.chromium.org/2727003002 to provide XPC
servers from different channels with a unique name.

BUG=720776

Review-Url: https://codereview.chromium.org/2884693002
Cr-Commit-Position: refs/heads/master@{#473538}
Committed:
https://chromium.googlesource.com/chromium/src/+/44554d6a63cde5ea96c5d315176d...
==========

[commit-bot: I haz the power, 2017-05-22 10:12:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44554d6a63cde5ea96c5d315176d...