Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2884603002: INPUT element: Do not update selectionStart/selectionEnd on |value| IDL setter if the new value is … (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
yoichio
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: Do not update selectionStart/selectionEnd on |value| IDL setter if the new value is same as the old value. The HTML standard was updated recently to clarify this behavior. The new behavior matches to TEXTAREA element, and Firefox 55. BUG=712352 Review-Url: https://codereview.chromium.org/2884603002 Cr-Commit-Position: refs/heads/master@{#472028} Committed: https://chromium.googlesource.com/chromium/src/+/7a3533d54795261d46e4e16d5a1bc5c07ecb087f

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -29 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
tkent
yoichio@, would you review this please? Red try bots are unrelated to this CL.
3 years, 7 months ago (2017-05-16 02:19:06 UTC) #12
yoichio
lgtm
3 years, 7 months ago (2017-05-16 03:51:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884603002/20001
3 years, 7 months ago (2017-05-16 04:29:05 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 06:07:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a3533d54795261d46e4e16d5a1b...

Powered by Google App Engine
This is Rietveld 408576698