Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 2884603002: INPUT element: Do not update selectionStart/selectionEnd on |value| IDL setter if the new value is … (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
index ce4e240ce86e72876143c138d279e2c930195438..e987b6e0e2ba09a628c5caca14f5ece8bb3b9c50 100644
--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
@@ -398,9 +398,7 @@ void HTMLTextAreaElement::SetValueCommon(
normalized_value.Replace('\r', '\n');
// Return early because we don't want to trigger other side effects when the
- // value isn't changing. This is interoperable though the specification
- // doesn't define so.
- // https://github.com/whatwg/html/issues/2412
+ // value isn't changing. This is interoperable.
if (normalized_value == value())
return;

Powered by Google App Engine
This is Rietveld 408576698