Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2884593003: Reverse the sense of the flag to make it easier to find test that need to be converted (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reverse the sense of the flag to make it easier to find test that need to be converted R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/27f9e5e4cee56527eb79b29983aa1b52b91968df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -82 lines) Patch
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_navigation_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_implemented_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_occurrences_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/set_priority_files_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_util.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/organize_directives_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 9 chunks +12 lines, -25 lines 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/statement_completion_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/plugin/set_analysis_domain_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/src/domain_abstract_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-15 14:59:51 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-15 15:20:00 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-15 15:40:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
27f9e5e4cee56527eb79b29983aa1b52b91968df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698